Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in eclass: cdrom.eclass

2012-01-18 Thread Mike Frysinger
On Wednesday 18 January 2012 06:45:59 Ulrich Mueller wrote: > > On Wed, 18 Jan 2012, Mike Frysinger wrote: > > ebuild: > > CDROM_OPTIONAL="yes" > > inherit cdrom > > > > eclass: > > if [[ ${CDROM_OPTIONAL} == "yes" ]] ; then > > PROPERTIES="cdinstall? ( interactive )" > > else > > PROP

Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in eclass: cdrom.eclass

2012-01-18 Thread Ulrich Mueller
> On Wed, 18 Jan 2012, Mike Frysinger wrote: >> CDROM_DISABLE_PROPERTIES=1 >> inherit [...] cdrom >> >> IUSE="cdinstall" >> PROPERTIES="cdinstall? ( interactive )" >> >> It would be required for 7 out of the 36 packages that use cdrom >> functions. > since USE=cdinstall has been our standar

Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in eclass: cdrom.eclass

2012-01-18 Thread Mike Frysinger
On Saturday 14 January 2012 11:03:18 Ulrich Mueller wrote: > > On Sat, 14 Jan 2012, Michael Sterrett wrote: > > Can you give an example of how you think it would be used in an > > ebuild? > > For example, like this: > >CDROM_DISABLE_PROPERTIES=1 >inherit [...] cdrom > >IUSE="cdin

Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in eclass: cdrom.eclass

2012-01-14 Thread Ulrich Mueller
> On Sat, 14 Jan 2012, Michael Sterrett wrote: > Can you give an example of how you think it would be used in an > ebuild? For example, like this: CDROM_DISABLE_PROPERTIES=1 inherit [...] cdrom IUSE="cdinstall" PROPERTIES="cdinstall? ( interactive )" It would be required for 7

Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in eclass: cdrom.eclass

2012-01-14 Thread Michael Sterrett
Can you give an example of how you think it would be used in an ebuild? 2012/1/14 "Paweł Hajdan, Jr." : > On 1/14/12 12:21 PM, Ulrich Mueller wrote: >> It can't be a USE flag, but something like the following might work: >> >> # @ECLASS-VARIABLE: CDROM_DISABLE_PROPERTIES >> # @DEFAULT_UNSET >> # @

Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in eclass: cdrom.eclass

2012-01-14 Thread Paweł Hajdan, Jr.
On 1/14/12 12:21 PM, Ulrich Mueller wrote: > It can't be a USE flag, but something like the following might work: > > # @ECLASS-VARIABLE: CDROM_DISABLE_PROPERTIES > # @DEFAULT_UNSET > # @DESCRIPTION: > # By default, the eclass sets PROPERTIES="interactive". > # A non-empty value of CDROM_DISABLE_P

Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in eclass: cdrom.eclass

2012-01-14 Thread Ulrich Mueller
> On Sat, 14 Jan 2012, Paweł Hajdan, Jr. wrote: >>> Don't set PROPERTIES=interactive, bug 398809. > How about this: set PROPERTIES=interactive by default (so it's > difficult to forget it), but allow the ebuilds to specify a USE flag > in case the interactive behavior is optional (maybe simil

[gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in eclass: cdrom.eclass

2012-01-14 Thread Ulrich Mueller
> On Fri, 13 Jan 2012, Markos Chandras wrote: > Please do not forget to update the ChangeLog file. It's covered by this entry: 13 Jan 2012; Ulrich Müller +cdrom.eclass: New cdrom.eclass, split out CD-ROM functions from eutils.eclass.

Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in eclass: cdrom.eclass

2012-01-13 Thread Paweł Hajdan, Jr.
On 1/14/12 12:36 AM, Markos Chandras wrote: > On 01/13/2012 10:35 PM, Ulrich Mueller (ulm) wrote: >> Don't set PROPERTIES=interactive, bug 398809. How about this: set PROPERTIES=interactive by default (so it's difficult to forget it), but allow the ebuilds to specify a USE flag in case the interac

[gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in eclass: cdrom.eclass

2012-01-13 Thread Markos Chandras
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 On 01/13/2012 10:35 PM, Ulrich Mueller (ulm) wrote: > Don't set PROPERTIES=interactive, bug 398809. Please do not forget to update the ChangeLog file. - -- Regards, Markos Chandras / Gentoo Linux Developer / Key ID: B4AFF2C2 -BEGIN PGP SIGNATUR