Re: [gentoo-dev] Proposed change to base.eclass: EAPI-2 support

2008-11-09 Thread Peter Alfredsen
On Sunday 02 November 2008, Peter Alfredsen wrote: > The attached patch for bug 238753 makes base.eclass support EAPI 2 > functions. Applied -- /PA signature.asc Description: This is a digitally signed message part.

Re: [gentoo-dev] Proposed change to base.eclass: EAPI-2 support

2008-11-02 Thread Peter Alfredsen
On Monday 03 November 2008, Donnie Berkholz wrote: > This eclass needs to do the same thing as the other eclasses that got > EAPI=2 patches and default EAPI to 0 when it's not defined, > everywhere where it tests the value of EAPI. Yes, that makes sense, though grepping for EAPI in eclass/ shows

Re: [gentoo-dev] Proposed change to base.eclass: EAPI-2 support

2008-11-02 Thread Donnie Berkholz
On 20:49 Sun 02 Nov , Donnie Berkholz wrote: > On 00:08 Mon 03 Nov , Peter Alfredsen wrote: > > +case "${EAPI}" in > > + 2) > > + EXPORT_FUNCTIONS src_unpack src_prepare src_configure > > src_compile src_install > > + ;; > > + *) > > + EXPORT_FUNCTIONS src

Re: [gentoo-dev] Proposed change to base.eclass: EAPI-2 support

2008-11-02 Thread Donnie Berkholz
On 00:08 Mon 03 Nov , Peter Alfredsen wrote: > +case "${EAPI}" in > + 2) > + EXPORT_FUNCTIONS src_unpack src_prepare src_configure > src_compile src_install > + ;; > + *) > + EXPORT_FUNCTIONS src_unpack src_compile src_install > + ;; > +e

Re: [gentoo-dev] Proposed change to base.eclass: EAPI-2 support

2008-11-02 Thread Peter Alfredsen
On Sunday 02 November 2008, Peter Alfredsen wrote: [...] Please just imagine that this is added to the end of the patch: - -EXPORT_FUNCTIONS src_unpack src_compile src_install /me had started hacking on this in-tree, and the first change was removing that line. -- /PA signature.asc Descripti

[gentoo-dev] Proposed change to base.eclass: EAPI-2 support

2008-11-02 Thread Peter Alfredsen
The attached patch for bug 238753 makes base.eclass support EAPI 2 functions. None of the previous functionality of exported functions is changed, so you can still do base_src_unpack autopatch. It's only the default actions of base_src_compile and base_src_unpack that's affected and only if EAP