> >
> > > "${pkg}.install" || die
> > > done
> > > }
> > >
> > > opam_src_install() {
> > > opam-install "${PN}"
> > > # Handle opam putting doc in a subdir
> > > if [ -d "${ED}/usr/share/doc/${PF}/${PN}" ] ; then
> >
> > Is PN always the correct subdirectory here
On Tue, 25 Jul 2017 16:18:10 +0200
Michał Górny wrote:
> On pon, 2017-07-24 at 17:20 +0200, Alexis Ballier wrote:
> > # Copyright 1999-2017 Gentoo Foundation
> > # Distributed under the terms of the GNU General Public License v2
> >
> > # @ECLASS: opam.eclass
> > # @MAINTAINER:
> > # Gentoo ML P
On pon, 2017-07-24 at 17:20 +0200, Alexis Ballier wrote:
> # Copyright 1999-2017 Gentoo Foundation
> # Distributed under the terms of the GNU General Public License v2
>
> # @ECLASS: opam.eclass
> # @MAINTAINER:
> # Gentoo ML Project
> # @AUTHOR:
> # Alexis Ballier
> # @BLURB: Provides functions
On wto, 2017-07-25 at 12:48 +, Peter Stuge wrote:
> Good work on the refactoring!
>
> Alexis Ballier wrote:
> > > > if [ -d "${ED}/usr/share/doc/${PF}/${PN}" ] ; then
> > >
> > > It’s always been recommended to me that we should use the [[ … ]]
> > > form.
> >
> > Doesn't make much
Good work on the refactoring!
Alexis Ballier wrote:
> > > if [ -d "${ED}/usr/share/doc/${PF}/${PN}" ] ; then
> >
> > It’s always been recommended to me that we should use the [[ … ]]
> > form.
>
> Doesn't make much difference here
Some; you need neither quote nor {} in expansions within [[
On Mon, 24 Jul 2017 18:11:39 -0400
"Aaron W. Swenson" wrote:
> On 2017-07-24 17:20, Alexis Ballier wrote:
> > Hey,
> >
> > Here is an eclass that would allow me to factor quite a bit of
> > redundant code.
> >
> > …
> > if [ -d "${ED}/usr/share/doc/${PF}/${PN}" ] ; then
>
> It’s always b
On 2017-07-24 17:20, Alexis Ballier wrote:
> Hey,
>
> Here is an eclass that would allow me to factor quite a bit of
> redundant code.
>
> …
> if [ -d "${ED}/usr/share/doc/${PF}/${PN}" ] ; then
It’s always been recommended to me that we should use the [[ … ]] form.
Otherwise, looks good t
Hey,
Here is an eclass that would allow me to factor quite a bit of
redundant code.
Potential users:
https://qa-reports.gentoo.org/output/genrdeps/dindex/dev-ml/opam
Examples of conversion:
diff --git a/dev-ml/ocaml-cstruct/ocaml-cstruct-3.1.1.ebuild
b/dev-ml/ocaml-cstruct/ocaml-cstruct-3.1.1.
