Re: [gentoo-dev] [RFC] games.eclass: move /etc/env.d/90games to a separate package

2014-02-02 Thread Ulrich Mueller
> On Sun, 02 Feb 2014, hasufell wrote: [gentoo-envd-0.ebuild] Seems I had missed this one: > rm -v "${EROOT%/}/etc/env.d/${GAMES_ENVD}" || die POSIX rm doesn't have a -v option, so better avoid it. Ulrich pgprZSiarBJJT.pgp Description: PGP signature

Re: [gentoo-dev] [RFC] games.eclass: move /etc/env.d/90games to a separate package

2014-02-02 Thread hasufell
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 02/02/2014 02:47 PM, Ciaran McCreesh wrote: > On Sun, 02 Feb 2014 14:45:12 +0100 hasufell > wrote: >> On 02/02/2014 02:43 PM, Ciaran McCreesh wrote: >>> On Sun, 02 Feb 2014 14:36:54 +0100 hasufell >>> wrote: * set homepage to games project pa

Re: [gentoo-dev] [RFC] games.eclass: move /etc/env.d/90games to a separate package

2014-02-02 Thread Ciaran McCreesh
On Sun, 02 Feb 2014 14:45:12 +0100 hasufell wrote: > On 02/02/2014 02:43 PM, Ciaran McCreesh wrote: > > On Sun, 02 Feb 2014 14:36:54 +0100 hasufell > > wrote: > >> * set homepage to games project page > > > > Why? Eclasses setting a homepage was never a good idea... > > > > The ebuild sets the

Re: [gentoo-dev] [RFC] games.eclass: move /etc/env.d/90games to a separate package

2014-02-02 Thread hasufell
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 02/02/2014 02:43 PM, Ciaran McCreesh wrote: > On Sun, 02 Feb 2014 14:36:54 +0100 hasufell > wrote: >> * set homepage to games project page > > Why? Eclasses setting a homepage was never a good idea... > The ebuild sets the homepage as described

Re: [gentoo-dev] [RFC] games.eclass: move /etc/env.d/90games to a separate package

2014-02-02 Thread Ciaran McCreesh
On Sun, 02 Feb 2014 14:36:54 +0100 hasufell wrote: > * set homepage to games project page Why? Eclasses setting a homepage was never a good idea... -- Ciaran McCreesh signature.asc Description: PGP signature

Re: [gentoo-dev] [RFC] games.eclass: move /etc/env.d/90games to a separate package

2014-02-02 Thread hasufell
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 ebuild: * use EAPI-5 * drop RDEPEND/DEPEND * drop useless elog * set homepage to games project page eclass: * use ${CATEGORY}/${PN} for the check -BEGIN PGP SIGNATURE- Version: GnuPG v2.0.22 (GNU/Linux) Comment: Using GnuPG with Thunderbird -

Re: [gentoo-dev] [RFC] games.eclass: move /etc/env.d/90games to a separate package

2014-02-02 Thread hasufell
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 02/02/2014 01:48 PM, Ulrich Mueller wrote: >> On Sun, 02 Feb 2014, hasufell wrote: >> SRC_URI="" > > Not needed. > Seems safer to me with "" in case games.eclass or any of those that it inherits add stuff to SRC_URI in the future. -BEGIN

Re: [gentoo-dev] [RFC] games.eclass: move /etc/env.d/90games to a separate package

2014-02-02 Thread hasufell
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 02/02/2014 01:48 PM, Ulrich Mueller wrote: >> On Sun, 02 Feb 2014, hasufell wrote: > >> https://bugs.gentoo.org/show_bug.cgi?id=417383 > > [gentoo-envd-0.ebuild] > >> EAPI=3 > > Why not newest EAPI? > I didn't feel comfortable about it si

Re: [gentoo-dev] [RFC] games.eclass: move /etc/env.d/90games to a separate package

2014-02-02 Thread Ulrich Mueller
> On Sun, 02 Feb 2014, hasufell wrote: > https://bugs.gentoo.org/show_bug.cgi?id=417383 [gentoo-envd-0.ebuild] > EAPI=3 Why not newest EAPI? > SRC_URI="" Not needed. > RDEPEND="" > DEPEND="" Ditto. [games.eclass.patch] > +if [[ ${PN} != "gentoo-envd" ]] ; then Better include ${CATEG

Re: [gentoo-dev] [RFC] games.eclass: move /etc/env.d/90games to a separate package

2014-02-02 Thread hasufell
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 02/02/2014 01:21 PM, hasufell wrote: > https://bugs.gentoo.org/show_bug.cgi?id=417383 > > reasons: * cleaner * easier to update/fix * proper config > protection > > any reason this was not done as a separate package in the first > place? > On se

[gentoo-dev] [RFC] games.eclass: move /etc/env.d/90games to a separate package

2014-02-02 Thread hasufell
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 https://bugs.gentoo.org/show_bug.cgi?id=417383 reasons: * cleaner * easier to update/fix * proper config protection any reason this was not done as a separate package in the first place? -BEGIN PGP SIGNATURE- Version: GnuPG v2.0.22 (GNU/Linux