Re: [gentoo-dev] [PATCHES] Header wrapping support for multilib

2013-04-04 Thread Michał Górny
On Thu, 4 Apr 2013 10:07:06 +0200 Alexis Ballier wrote: > > It will be when there's a safe, public API for it. Right now, it's too > > fragile. > > What exactly is the unsafe part of the API of this function ? Well, the first thing was using $ABI directly, and I sent a patch for that one alread

Re: [gentoo-dev] [PATCHES] Header wrapping support for multilib

2013-04-04 Thread Alexis Ballier
On Tue, 2 Apr 2013 13:47:07 +0200 Michał Górny wrote: [...] > > - Header wrapping really has nothing to do with autotools and I > > strongly believe this should be moved to multilib-build. > > It will be when there's a safe, public API for it. Right now, it's too > fragile. > The problem is t

Re: [gentoo-dev] [PATCHES] Header wrapping support for multilib

2013-04-02 Thread Michał Górny
On Tue, 2 Apr 2013 12:59:43 +0200 Alexis Ballier wrote: > On Mon, 1 Apr 2013 11:19:51 +0200 > Michał Górny wrote: > > > On Sat, 23 Mar 2013 17:25:32 +0100 > > Michał Górny wrote: > > > > > I've finally got around to writing the header wrapping functions for > > > multilib. That's an initial y

Re: [gentoo-dev] [PATCHES] Header wrapping support for multilib

2013-04-02 Thread Alexis Ballier
On Mon, 1 Apr 2013 11:19:51 +0200 Michał Górny wrote: > On Sat, 23 Mar 2013 17:25:32 +0100 > Michał Górny wrote: > > > I've finally got around to writing the header wrapping functions for > > multilib. That's an initial yet working draft. I will send patches > > in reply to this mail. > > Comm

Re: [gentoo-dev] [PATCHES] Header wrapping support for multilib

2013-04-01 Thread Michał Górny
On Sat, 23 Mar 2013 17:25:32 +0100 Michał Górny wrote: > I've finally got around to writing the header wrapping functions for > multilib. That's an initial yet working draft. I will send patches in > reply to this mail. Committed. -- Best regards, Michał Górny signature.asc Description: PGP

Re: [gentoo-dev] [PATCHES] Header wrapping support for multilib

2013-03-23 Thread Diego Elio Pettenò
On 23/03/2013 18:32, Michał Górny wrote: > While at it, is '#elif' portable enough here? I see it in C99 but you > probably know more about it than I do. I'd say it's portable enough, I'm pretty sure it exists before C99 as well — and worst case scenario it'll explode in our face, not silently. -

Re: [gentoo-dev] [PATCHES] Header wrapping support for multilib

2013-03-23 Thread Michał Górny
On Sat, 23 Mar 2013 17:46:18 +0100 Diego Elio Pettenò wrote: > On 23/03/2013 17:25, Michał Górny wrote: > > - no 'fallback' code in header (to be added in the future), if no ABIs > > match, no code is given, > > Please don't commit this without a fallback that at the very least > #errors out —

Re: [gentoo-dev] [PATCHES] Header wrapping support for multilib

2013-03-23 Thread Diego Elio Pettenò
On 23/03/2013 17:25, Michał Górny wrote: > - no 'fallback' code in header (to be added in the future), if no ABIs > match, no code is given, Please don't commit this without a fallback that at the very least #errors out — I don't want silent issues. -- Diego Elio Pettenò — Flameeyes flamee...@

[gentoo-dev] [PATCHES] Header wrapping support for multilib

2013-03-23 Thread Michał Górny
Hello, I've finally got around to writing the header wrapping functions for multilib. That's an initial yet working draft. I will send patches in reply to this mail. The first patch just converts internal distutils-r1 root merging function to globally available multibuild_merge_root(). This is us