Re: [gentoo-dev] [PATCH v5] greadme.eclass: new eclass

2024-07-23 Thread Ulrich Mueller
> On Tue, 23 Jul 2024, Florian Schmaus wrote: >> Having more than one element in REPLACING_VERSIONS is certainly a >> corner case, but I still wonder about the logic. Shouldn't it be >> the other way around, i.e. if there is _any_ empty ${_GREADME_SHOW} >> then there is an identical file insta

Re: [gentoo-dev] [PATCH v5] greadme.eclass: new eclass

2024-07-23 Thread Florian Schmaus
On 21/07/2024 10.26, Ulrich Mueller wrote: On Tue, 16 Jul 2024, Florian Schmaus wrote: Notes: - also show readme contents if FEATURES=nodoc Good. :) Thanks for your review. --- /dev/null +++ b/eclass/greadme.eclass @@ -0,0 +1,257 @@ +# Copyright 1999-2024 Gentoo Authors +# Distribu

Re: [gentoo-dev] [PATCH v5] greadme.eclass: new eclass

2024-07-21 Thread Ulrich Mueller
> On Tue, 16 Jul 2024, Florian Schmaus wrote: > Notes: > - also show readme contents if FEATURES=nodoc Good. :) > --- /dev/null > +++ b/eclass/greadme.eclass > @@ -0,0 +1,257 @@ > +# Copyright 1999-2024 Gentoo Authors > +# Distributed under the terms of the GNU General Public License v2

[gentoo-dev] [PATCH v5] greadme.eclass: new eclass

2024-07-16 Thread Florian Schmaus
This new eclass includes various improvements over the existing readme.gentoo-r1.eclass. First, the content of README.gentoo will only be shown on new installations or if it has changed between updates. Second, it allows the composition of readme via bash's heredoc. And finally, the eclass expor