Re: [gentoo-dev] [PATCH v4] greadme.eclass: new eclass

2024-06-19 Thread Florian Schmaus
On 19/06/2024 10.32, Ulrich Mueller wrote: On Tue, 18 Jun 2024, Florian Schmaus wrote: Any preference regarding the auto-formatting tool? The readme.gentoo-r1.eclass uses fold, but fmt (both are in coreutils) would probably also be an option (and has a --uniform-spacing option ;)). readme.ge

Re: [gentoo-dev] [PATCH v4] greadme.eclass: new eclass

2024-06-19 Thread Ulrich Mueller
> On Tue, 18 Jun 2024, Florian Schmaus wrote: > Any preference regarding the auto-formatting tool? The > readme.gentoo-r1.eclass uses fold, but fmt (both are in coreutils) > would probably also be an option (and has a --uniform-spacing option > ;)). readme.gentoo.eclass originally had fmt, bu

Re: [gentoo-dev] [PATCH v4] greadme.eclass: new eclass

2024-06-18 Thread Florian Schmaus
On 18/06/2024 20.21, Arthur Zamarin wrote: On 18/06/2024 17.53, Florian Schmaus wrote: Thanks for pointing this out. I think I understand now what arthur is asking for: src_install() {     ...     local DOC_CONTENTS="My README.Gentoo contents"     readme.gentoo_create_doc } @arthur: is that

Re: [gentoo-dev] [PATCH v4] greadme.eclass: new eclass

2024-06-18 Thread Ionen Wolkens
On Tue, Jun 18, 2024 at 09:21:56PM +0300, Arthur Zamarin wrote: > On 18/06/2024 17.53, Florian Schmaus wrote: > > On 18/06/2024 16.02, Ulrich Mueller wrote: > >>> On Tue, 18 Jun 2024, Florian Schmaus wrote: > > Finally, unlike readme.gentoo-r1.elcass, this eclass does not need > > to st

Re: [gentoo-dev] [PATCH v4] greadme.eclass: new eclass

2024-06-18 Thread Arthur Zamarin
On 18/06/2024 17.53, Florian Schmaus wrote: > On 18/06/2024 16.02, Ulrich Mueller wrote: >>> On Tue, 18 Jun 2024, Florian Schmaus wrote: > Finally, unlike readme.gentoo-r1.elcass, this eclass does not need > to store the content of the readme in an environment variable. Not > having

Re: [gentoo-dev] [PATCH v4] greadme.eclass: new eclass

2024-06-18 Thread Florian Schmaus
On 18/06/2024 16.02, Ulrich Mueller wrote: On Tue, 18 Jun 2024, Florian Schmaus wrote: Finally, unlike readme.gentoo-r1.elcass, this eclass does not need to store the content of the readme in an environment variable. Not having to store the content in an environment variable reduces the pollutio

Re: [gentoo-dev] [PATCH v4] greadme.eclass: new eclass

2024-06-18 Thread Ulrich Mueller
> On Tue, 18 Jun 2024, Florian Schmaus wrote: >>> Finally, unlike readme.gentoo-r1.elcass, this eclass does not need >>> to store the content of the readme in an environment variable. Not >>> having to store the content in an environment variable reduces the >>> pollution of the environment (s

Re: [gentoo-dev] [PATCH v4] greadme.eclass: new eclass

2024-06-18 Thread Florian Schmaus
Hi Arthur, thanks for your mail. On 16/06/2024 20.15, Arthur Zamarin wrote: On 16/06/2024 18.51, Florian Schmaus wrote: This new eclass includes various improvements over the existing readme.gentoo-r1.eclass. So, some weird question from me - why is it called greadme? I can understand why yo

Re: [gentoo-dev] [PATCH v4] greadme.eclass: new eclass

2024-06-16 Thread Ulrich Mueller
> On Sun, 16 Jun 2024, Florian Schmaus wrote: > First, the content of README.gento will only be shown on new Typo. > +greadme_pkg_postinst() { > + debug-print-function ${FUNCNAME} "${@}" > + > + if [[ ! -v _GREADME_SHOW ]]; then > + die "_GREADME_SHOW not set. Did you cal

Re: [gentoo-dev] [PATCH v4] greadme.eclass: new eclass

2024-06-16 Thread Arthur Zamarin
On 16/06/2024 18.51, Florian Schmaus wrote: > This new eclass includes various improvements over the existing > readme.gentoo-r1.eclass. So, some weird question from me - why is it called greadme? I can understand why you don't want to modify existing eclass, but why not call it "readme.gentoo-r2.

[gentoo-dev] [PATCH v4] greadme.eclass: new eclass

2024-06-16 Thread Florian Schmaus
This new eclass includes various improvements over the existing readme.gentoo-r1.eclass. First, the content of README.gento will only be shown on new installations or if it has changed between updates. Second, it allows the composition of readme via bash's heredoc. Third, it exports phase functi