Re: [gentoo-dev] [PATCH v3] eclass/kernel-2.eclass: Remove use of tr in global scope

2017-09-07 Thread Ciaran McCreesh
On Thu, 07 Sep 2017 07:42:31 +0200 Michał Górny wrote: > >+if [[ "${EAPI}" -lt 6 ]]; then > > EAPI is not a number. The next one we'll call gray-grizzly just to > prove the point. Careful, you're turning into me. -- Ciaran McCreesh

Re: [gentoo-dev] [PATCH v3] eclass/kernel-2.eclass: Remove use of tr in global scope

2017-09-06 Thread Michał Górny
Dnia 7 września 2017 01:40:50 CEST, Mike Pagano napisał(a): >This time, use bash 4.0, but limit the use of this function to ebuild >that have EAPI >= 6. >Display a warning for maintainers to upgrade their ebuilds, or remove >the call. >Thanks to mgorny for the suggestion. > >Signed-off-by: Mike Pa

Re: [gentoo-dev] [PATCH v3] eclass/kernel-2.eclass: Remove use of tr in global scope

2017-09-06 Thread Floyd Anderson
Hello, some remarks below ... On Mi, 06 Sep 23:40:50 + Mike Pagano wrote: This time, use bash 4.0, but limit the use of this function to ebuild that have EAPI >= 6. Display a warning for maintainers to upgrade their ebuilds, or remove the call. Thanks to mgorny for the suggestion. Signe

[gentoo-dev] [PATCH v3] eclass/kernel-2.eclass: Remove use of tr in global scope

2017-09-06 Thread Mike Pagano
This time, use bash 4.0, but limit the use of this function to ebuild that have EAPI >= 6. Display a warning for maintainers to upgrade their ebuilds, or remove the call. Thanks to mgorny for the suggestion. Signed-off-by: Mike Pagano --- eclass/kernel-2.eclass | 20 +--- 1 file