Re: [gentoo-dev] [PATCH v3] eclass/dune.eclass: fix dune-install function

2021-12-09 Thread Ulrich Mueller
> On Fri, 10 Dec 2021, Ulrich Mueller wrote: > I'd write something like this: > local -a pkgs=("$@") > [[ ${#pkgs[@]} -eq 0 ]] && pkgs=(${DUNE_PKG_NAME}) Looks like I'm not immune against missing quotes either. :/ The line should read: [[ ${#pkgs[@]} -eq 0 ]] && pkgs=("$

Re: [gentoo-dev] [PATCH v3] eclass/dune.eclass: fix dune-install function

2021-12-09 Thread Ulrich Mueller
> On Thu, 09 Dec 2021, Maciej Barć wrote: > dune-install() { > + local pkgs > + if [[ -n "${@}" ]] ; then > + pkgs="${@}" Here pkgs is a scalar ... > + else > + pkgs=${DUNE_PKG_NAME} > + fi > + > + local myduneopts=( > + --prefix="${ED

[gentoo-dev] [PATCH v3] eclass/dune.eclass: fix dune-install function

2021-12-09 Thread Maciej Barć
Support EAPI 8 and drop support for EAPI 5. Set DUNE_PKG_NAME to PN by default. Move "Move docs to the appropriate place" block to dune-install to make dune-install now handle a list of subpackages correctly. Signed-off-by: Maciej Barć --- eclass/dune.eclass | 50