Re: [gentoo-dev] [PATCH v2] eclass/dune.eclass: fixes

2021-12-09 Thread Maciej Barć
> May be worth splitting the commit into a few different changes > so the summary can be more informative than "fixes" > (try git add -p). Actually the more accurate summary would be "fix dune-install function". I wouldn't split it imo. On 12/9/21 23:29, Sam James wrote: On 9 Dec 2021, at 2

Re: [gentoo-dev] [PATCH v2] eclass/dune.eclass: fixes

2021-12-09 Thread Sam James
> On 9 Dec 2021, at 22:10, Maciej Barć wrote: > > bump to EAPI 8 Say "support EAPI 8" instead. May be worth splitting the commit into a few different changes so the summary can be more informative than "fixes" (try git add -p). lgtm otherwise, thanks for doing this! > drop support for EAPI

[gentoo-dev] [PATCH v2] eclass/dune.eclass: fixes

2021-12-09 Thread Maciej Barć
bump to EAPI 8 drop support for EAPI 5 set DUNE_PKG_NAME to PN by default move "Move docs to the appropriate place" block to dune-install to make dune-install now handle a list of subpackages correctly Signed-off-by: Maciej Barć --- eclass/dune.eclass | 50 ---