Re: [gentoo-dev] [PATCH 1/4] desktop.eclass: domenu, fix dying on non-existing files

2018-07-26 Thread Mike Gilbert
On Thu, Jul 26, 2018 at 7:35 AM Michał Górny wrote: > > The weird logic in domenu had an explicit separate clause > for unsuccessful return on non-existing files. This worked fine before > EAPI 4 since '|| die' was mandatory. However, since 'doins' started > dying on its own, developers have ass

[gentoo-dev] [PATCH 1/4] desktop.eclass: domenu, fix dying on non-existing files

2018-07-26 Thread Michał Górny
The weird logic in domenu had an explicit separate clause for unsuccessful return on non-existing files. This worked fine before EAPI 4 since '|| die' was mandatory. However, since 'doins' started dying on its own, developers have assumed the same for 'domenu' and stopped checking the exit status