Re: [gentoo-dev] [PATCH] systemd.eclass: set BDEPEND for EAPI 7

2018-08-09 Thread Michael Orlitzky
On 08/06/2018 04:23 PM, Toralf Förster wrote: > On 08/06/2018 10:09 PM, Alec Warner wrote: >> >> They do not even do so by convention; there are numerous EAPIs in the >> wild that are non-numeric. > > Then this line > >if [[ ${EAPI} == [0123456] ]]; then > > is a short-term solution, rig

Re: [gentoo-dev] [PATCH] systemd.eclass: set BDEPEND for EAPI 7

2018-08-06 Thread Toralf Förster
On 08/06/2018 10:09 PM, Alec Warner wrote: > > They do not even do so by convention; there are numerous EAPIs in the > wild that are non-numeric. Then this line if [[ ${EAPI} == [0123456] ]]; then is a short-term solution, right? -- Toralf PGP 23217DA7 9B888F45 signature.asc Descr

Re: [gentoo-dev] [PATCH] systemd.eclass: set BDEPEND for EAPI 7

2018-08-06 Thread Alec Warner
On Mon, Aug 6, 2018 at 3:51 PM, Mike Gilbert wrote: > On Mon, Aug 6, 2018 at 3:35 PM Vadim A. Misbakh-Soloviov > wrote: > > > > В письме от понедельник, 6 августа 2018 г. 22:13:49 MSK пользователь > Ulrich > > Mueller написал: > > > > On Mon, 6 Aug 2018, Mike Gilbert wrote: > > > > -DEPEND="

Re: [gentoo-dev] [PATCH] systemd.eclass: set BDEPEND for EAPI 7

2018-08-06 Thread Mike Gilbert
On Mon, Aug 6, 2018 at 3:35 PM Vadim A. Misbakh-Soloviov wrote: > > В письме от понедельник, 6 августа 2018 г. 22:13:49 MSK пользователь Ulrich > Mueller написал: > > > On Mon, 6 Aug 2018, Mike Gilbert wrote: > > > -DEPEND="virtual/pkgconfig" > > > +if [[ ${EAPI} == [0123456] ]]; then > > > >

Re: [gentoo-dev] [PATCH] systemd.eclass: set BDEPEND for EAPI 7

2018-08-06 Thread Ulrich Mueller
> On Mon, 06 Aug 2018, Vadim A Misbakh-Soloviov wrote: > Anyway, I think, it is possible to add something like > "EAPI=${EAPI:-0}" somewhere at the top of eclass, to don't call > "${EAPI:-0}" each time when EAPI variable is needed. No, that is not possible. Changing EAPI in an eclass would ma

Re: [gentoo-dev] [PATCH] systemd.eclass: set BDEPEND for EAPI 7

2018-08-06 Thread Vadim A. Misbakh-Soloviov
В письме от понедельник, 6 августа 2018 г. 22:13:49 MSK пользователь Ulrich Mueller написал: > > On Mon, 6 Aug 2018, Mike Gilbert wrote: > > -DEPEND="virtual/pkgconfig" > > +if [[ ${EAPI} == [0123456] ]]; then > > This should use ${EAPI:-0} because for EAPI 0 the variable can be > empty. > >

Re: [gentoo-dev] [PATCH] systemd.eclass: set BDEPEND for EAPI 7

2018-08-06 Thread Ulrich Mueller
> On Mon, 6 Aug 2018, Mike Gilbert wrote: > -DEPEND="virtual/pkgconfig" > +if [[ ${EAPI} == [0123456] ]]; then This should use ${EAPI:-0} because for EAPI 0 the variable can be empty. > + DEPEND="virtual/pkgconfig" > +else > + BDEPEND="virtual/pkgconfig" > +fi

[gentoo-dev] [PATCH] systemd.eclass: set BDEPEND for EAPI 7

2018-08-06 Thread Mike Gilbert
--- eclass/systemd.eclass | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/eclass/systemd.eclass b/eclass/systemd.eclass index 72f4845efc45..b822f54f8d06 100644 --- a/eclass/systemd.eclass +++ b/eclass/systemd.eclass @@ -26,11 +26,15 @@ inherit toolchain-funcs case $