> On 27 Mar 2021, at 22:21, Sam James wrote:
>
Given how uncontroversial most of it is, the positive reviews, and the fact
that I pushed a load
of other eclassdoc changes (for other eclasses) but CI is still down, it makes
sense to throw in as much as we can to not waste the big cache regenera
> On 28 Mar 2021, at 13:46, Ulrich Mueller wrote:
>
>
>>> On Sun, 28 Mar 2021, David Seifert wrote:
>> This is just bringing it in line with the rest of the eclass. You know,
>> consistency.
>
> If that's the goal then the patch should update all occurences, though.
Well, that was defi
> On Sun, 28 Mar 2021, David Seifert wrote:
> This is just bringing it in line with the rest of the eclass. You know,
> consistency.
If that's the goal then the patch should update all occurences, though.
Especially those where usage is inconsistent within the same line.
signature.asc
Descr
Hi,
Thank you for doing this. LGTM modulo a few nits below.
On Sat, 2021-03-27 at 22:21 +, Sam James wrote:
> - if [[ ${EBUILD_PHASE} != "unpack" && ${EBUILD_PHASE} != "prepare" ]];
> then
> - ewarn "QA Warning: running $1 in ${EBUILD_PHASE} phase"
> + if [[ ${EBUILD_PHA
On Sat, 2021-03-27 at 22:21 +, Sam James wrote:
> (Relatively) significant changes:
> * inherit eutils for < EAPI 7 for eqawarn
> * mark WANT_AUTO*, AUTOTOOLS_AUTO_DEPEND as @PRE_INHERIT
> * convert phase test to EBUILD_PHASE_FUNC
> * drop support for < EAPI 5
LGTM
On Sun, 2021-03-28 at 10:13 +0200, Ulrich Mueller wrote:
> > > > > > On Sat, 27 Mar 2021, Sam James wrote:
>
> > -if [[ -z ${_AUTOTOOLS_ECLASS} ]]; then
> > +if [[ -z ${_AUTOTOOLS_ECLASS} ]] ; then
>
> This just adds unnecessary noise to the git history. We don't have any
> policy on whitespace
> On Sat, 27 Mar 2021, Sam James wrote:
> -if [[ -z ${_AUTOTOOLS_ECLASS} ]]; then
> +if [[ -z ${_AUTOTOOLS_ECLASS} ]] ; then
This just adds unnecessary noise to the git history. We don't have any
policy on whitespace before punctuation marks, but the examples in the
Bash manual don't have wh
Looks good to me.
(Relatively) significant changes:
* inherit eutils for < EAPI 7 for eqawarn
* mark WANT_AUTO*, AUTOTOOLS_AUTO_DEPEND as @PRE_INHERIT
* convert phase test to EBUILD_PHASE_FUNC
* drop support for < EAPI 5
[Needed for the EBUILD_PHASE_FUNC change.
< EAPI 5 is no longer in ::gentoo (since December).]
