Re: [gentoo-dev] Add Hooks to Eselect

2023-08-21 Thread konsolebox
On Tue, Aug 22, 2023, 02:50 Ulrich Mueller, wrote: > > On Mon, 21 Aug 2023, konsolebox wrote: > > > This actually allows users to virtually extend an eselect module without > > needing to fork it. The things people can do are endless. > > This isn't what eselect modules were designed for. T

Re: [gentoo-dev] Add Hooks to Eselect

2023-08-21 Thread Redjard
On 2023-08-21 20:50:39, Ulrich Mueller wrote: > First, changing a low-level function like check_do() is really a no-no, > because this function is documented in the eselect developer guide and > third-party modules may rely on it. The documentation, as far as I can tell, states only > check_do

Re: [gentoo-dev] Add Hooks to Eselect

2023-08-21 Thread Ulrich Mueller
> On Mon, 21 Aug 2023, konsolebox wrote: > This actually allows users to virtually extend an eselect module without > needing to fork it. The things people can do are endless. This isn't what eselect modules were designed for. They are specialised tools that are supposed to do one thing, an

Re: [gentoo-dev] Add Hooks to Eselect

2023-08-21 Thread konsolebox
On Mon, Aug 21, 2023, 18:00 Ulrich Mueller, wrote: > Sorry, but I don't see much incentive for adding such a hook mechanism. > This actually allows users to virtually extend an eselect module without needing to fork it. The things people can do are endless. Even now I just thought about using

Re: [gentoo-dev] Re: Add Hooks to Eselect

2023-08-21 Thread konsolebox
On Mon, Aug 21, 2023, 08:15 Duncan, <1i5t5.dun...@cox.net> wrote: > Suggestion: A more flexible approach would make pre/post directories, > Or allow both file and directories. > do [[ > # maybe skip either the executable or README test? > # or perhaps only match

[gentoo-dev] [PATCH] metadata: Add stabilisation group for Ansible

2023-08-21 Thread Marek Szuba
Signed-off-by: Marek Szuba --- metadata/stabilization-groups/ansible | 2 ++ 1 file changed, 2 insertions(+) create mode 100644 metadata/stabilization-groups/ansible diff --git a/metadata/stabilization-groups/ansible b/metadata/stabilization-groups/ansible new file mode 100644 index 00

[gentoo-dev] [RFC PATCH] Add Ansible package-stabilisation group

2023-08-21 Thread Marek Szuba
This is very much for future reference, seeing as stabilisation groups are still very much work in progress. Anyway, the point here is to make it easier to avoid in the future the fairly regular occurrence of Portage complaining about having to hold back newly stabilised Ansible Core owing to versi

Re: [gentoo-dev] Add Hooks to Eselect

2023-08-21 Thread Ulrich Mueller
> On Mon, 21 Aug 2023, Redjard wrote: > I did consider doing so, however with that approach my effective fork > of the kernel.eselect module would get continually outdated, while a > wrapper module requires a different command [...] Not necessarily. It could use the same name as the original

Re: [gentoo-dev] Add Hooks to Eselect

2023-08-21 Thread Redjard
On 2023-08-21 12:00:18, Ulrich Mueller wrote: In addition to user patches, you can also put your own modules in the ${HOME}/.eselect/modules/ directory. For example, you could either copy kernel.eselect to there and modify it. Or, you could have a mykernel.eselect module, along these lines: I d

[gentoo-dev] Re: Add Hooks to Eselect

2023-08-21 Thread Redjard
On 2023-08-21 02:15:08, Duncan wrote: Suggestion: A more flexible approach would make pre/post directories, such that "any" file therein (exceptions for backups, etc) would be sourced. In run_hook something like (as written assumes bashisms OK, didn't verify if that's valid for eselect or no

Re: [gentoo-dev] Add Hooks to Eselect

2023-08-21 Thread Ulrich Mueller
> On Mon, 21 Aug 2023, Redjard wrote: > To roughly summarize, I was asking for a method to hook into eselect, > to modify the behavior of eselect kernel set. > I was pointed in the direction of a user patch by konsolebox, and > consequently wrote the patch. In addition to user patches, you c

[gentoo-dev] [PATCH 1/1] secureboot.eclass: error out early if signing key/cert not readable

2023-08-21 Thread Andrew Ammerlaan
Hi all, This patch is similar to the one I sent earlier for kernel-build.eclass. Instead of checking if the signing key/cert exists we now also check if we can actually read it. Also removed an extra "#" that prevents the documentation from rendering as intended. Best regards, Andrew diff -

Re: [gentoo-dev] Add Hooks to Eselect

2023-08-21 Thread Redjard
On 2023-08-19 06:58:10, Michał Górny wrote: You have to provide the rationale here. You can't expect people to sign up for some shady third-party service to read it. My bad, not much of value is locked in the proprietary service but I should have stated as such. To roughly summarize, I was aski

[gentoo-dev] [PATCH 1/1]: kernel-build.eclass: error out early if signing key not readable

2023-08-21 Thread Andrew Ammerlaan
Hi all, Currently if the MODULES_SIGN_KEY exists but is not readable the kernel will fail to compile. The kernel build system does not produce a clear error when this happens so it is not immediately obvious what is wrong. This small patch adjusts our src_prepare logic to check if the signing