On Sun, May 28, 2023 at 08:41:16AM -0400, Ionen Wolkens wrote:
> Likely final as far as initial merge goes.
>
> Given been suggested that it'd be easier to have it in the tree for
> testing and that without consumers it can't break anything (yet),
> planning to merge tomorrow. Just posting update
Signed-off-by: Volkmar W. Pogatzki
---
eclass/java-pkg-simple.eclass | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/eclass/java-pkg-simple.eclass b/eclass/java-pkg-simple.eclass
index 929ce68c6c07..46fc036637d8 100644
--- a/eclass/java-pkg-simple.eclass
+++ b/eclass/java
> On Mon, 29 May 2023, Volkmar W Pogatzki wrote:
> +if [[ ${SLOT} = 0 ]]; then
> +: "${JAVA_LAUNCHER_FILENAME:=${PN}}"
> +else
> : "${JAVA_LAUNCHER_FILENAME:=${PN}-${SLOT}}"
> +fi
Please indent the lines in the then and else blocks.
signature.asc
Description: PGP signature
> On Mon, 29 May 2023, Volkmar W Pogatzki wrote:
>> > -: "${JAVA_LAUNCHER_FILENAME:=${PN}-${SLOT}}"
>> > +if [[ ${SLOT} = 0 ]]; then
>> > + JAVA_LAUNCHER_FILENAME="${PN}"
>> > +else
>> > + JAVA_LAUNCHER_FILENAME="${PN}-${SLOT}"
>> > +fi
>>
>> This will no longer allow overriding the variabl
Avoids the need for setting JAVA_LAUNCHER_FILENAME="${PN}" if SLOT is 0.
Signed-off-by: Volkmar W. Pogatzki
---
eclass/java-pkg-simple.eclass | 4
1 file changed, 4 insertions(+)
diff --git a/eclass/java-pkg-simple.eclass b/eclass/java-pkg-simple.eclass
index 929ce68c6c07..a57fae02ffd7 100
> Ulrich Mueller hat am 26.05.2023 10:44 CEST geschrieben:
>
>
> > On Fri, 26 May 2023, Volkmar W Pogatzki wrote:
>
> > -: "${JAVA_LAUNCHER_FILENAME:=${PN}-${SLOT}}"
> > +if [[ ${SLOT} = 0 ]]; then
> > + JAVA_LAUNCHER_FILENAME="${PN}"
> > +else
> > + JAVA_LAUNCHER_FILENAME="${PN}-${SLO
