> On Fri, 10 Dec 2021, Ulrich Mueller wrote:
> I'd write something like this:
> local -a pkgs=("$@")
> [[ ${#pkgs[@]} -eq 0 ]] && pkgs=(${DUNE_PKG_NAME})
Looks like I'm not immune against missing quotes either. :/
The line should read:
[[ ${#pkgs[@]} -eq 0 ]] && pkgs=("$
> On Thu, 09 Dec 2021, Maciej Barć wrote:
> dune-install() {
> + local pkgs
> + if [[ -n "${@}" ]] ; then
> + pkgs="${@}"
Here pkgs is a scalar ...
> + else
> + pkgs=${DUNE_PKG_NAME}
> + fi
> +
> + local myduneopts=(
> + --prefix="${ED
Support EAPI 8 and drop support for EAPI 5.
Set DUNE_PKG_NAME to PN by default.
Move "Move docs to the appropriate place" block to dune-install
to make dune-install now handle a list of subpackages correctly.
Signed-off-by: Maciej Barć
---
eclass/dune.eclass | 50
> May be worth splitting the commit into a few different changes
> so the summary can be more informative than "fixes"
> (try git add -p).
Actually the more accurate summary would be "fix dune-install function".
I wouldn't split it imo.
On 12/9/21 23:29, Sam James wrote:
On 9 Dec 2021, at 2
> On 9 Dec 2021, at 22:10, Maciej Barć wrote:
>
> bump to EAPI 8
Say "support EAPI 8" instead.
May be worth splitting the commit into a few different changes
so the summary can be more informative than "fixes"
(try git add -p).
lgtm otherwise, thanks for doing this!
> drop support for EAPI
bump to EAPI 8
drop support for EAPI 5
set DUNE_PKG_NAME to PN by default
move "Move docs to the appropriate place" block to dune-install
to make dune-install now handle a list of subpackages correctly
Signed-off-by: Maciej Barć
---
eclass/dune.eclass | 50 ---
On Thu, 2021-12-09 at 21:11 +0500, Anna Vyalkova wrote:
> It is useful for verifying distfiles that come from OpenBSD folks, since
> signify produces signatures incompatible with GnuPG.
>
> Signed-off-by: Anna Vyalkova
> ---
> Changes from previous patch:
>
> - changed variable name
> VERIFY_SIG
oops, forgot `v2` in subject.
Added it all the time during pre-send tests, and missed when sent it for real
:facepalm:
signature.asc
Description: This is a digitally signed message part.
Some grammars packages (like, for example, tree-sitter-agda) uses
different versioning scheme from vast majority of grammars in
tree-sitter github organization.
Also, third-party grammars doesn't follow tree-sitter versioning.
Also, some grammars (like tree-sitter-haskell, for example)
On Thu, 2021-12-09 at 13:23 +, Marek Szuba wrote:
> Has been deprecated for quite a while now, comes from eutils.eclass
> so it blocks EAPI 8+. Just call mktemp directly.
>
> Signed-off-by: Marek Szuba
> ---
> eclass/gnome2-utils.eclass | 7 +++
> 1 file changed, 3 insertions(+), 4 delet
Signed-off-by: Marek Szuba
---
eclass/gnome2.eclass | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/eclass/gnome2.eclass b/eclass/gnome2.eclass
index c6d93a46bfe..0414d5cd5f3 100644
--- a/eclass/gnome2.eclass
+++ b/eclass/gnome2.eclass
@@ -4,7 +4,7 @@
# @ECLASS: gnome2.ec
Signed-off-by: Marek Szuba
---
eclass/gnome2.eclass | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/eclass/gnome2.eclass b/eclass/gnome2.eclass
index 4b7c3acac06..c6d93a46bfe 100644
--- a/eclass/gnome2.eclass
+++ b/eclass/gnome2.eclass
@@ -21,14 +21,14 @@ GNOME2_EAUTORECON
No longer available for EAPI-8+, and gnome2_src_prepare already calls
xdg_environment_reset via gnome2_environment_reset. All that function
did otherwise was call default src_prepare for EAPI-6+ so do just that
directly.
Signed-off-by: Marek Szuba
---
eclass/gnome2.eclass | 4 ++--
1 file change
Trivial now that emktemp is gone.
While at it, include eclass name in the "EAPI x not supported" error
message.
Signed-off-by: Marek Szuba
---
eclass/gnome2-utils.eclass | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/eclass/gnome2-utils.eclass b/eclass/gnome2-utils.ecl
Has been deprecated for quite a while now, comes from eutils.eclass
so it blocks EAPI 8+. Just call mktemp directly.
Signed-off-by: Marek Szuba
---
eclass/gnome2-utils.eclass | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/eclass/gnome2-utils.eclass b/eclass/gnome2-uti
EHLO,
Unless I have messed something up these are all the changes required
to make these two eclasses support EAPI 8. Comments welcome!
Nb. I am not the official maintainer of these eclasses, that said I did
discuss working on updating them for EAPI 8 with leio on IRC.
--
Marecki
> IIUC, the space separated list of arguments is assigned to pkgs, with
> a fallback to ${DUNE_PKG_NAME}. The 'for pkg in "${pkgs}"' loop isn't
> actually a loop because ${pkgs} is inside double quotes, so it will be
> executed only once with pkg being equal to pkgs.
Yes, you are right, I was wro
On Thu, 2021-12-09 at 14:42 +0500, Anna Vyalkova wrote:
> It is useful for verifying distfiles that come from OpenBSD folks, since
> signify produces signatures incompatible with GnuPG.
For the record, I don't like the fact that OpenBSD reinvents the wheel
but I'm not going to oppose the patch.
>
18 matches
Mail list logo
