Re: [gentoo-dev] dynamic groups and users

2019-08-07 Thread Jaco Kroon
Hi Michał, On 2019/08/07 17:48, Michał Górny wrote: > On Tue, 2019-08-06 at 13:41 +0200, Jaco Kroon wrote: >> Hi Guys, >> >> > Attaching. It seems for some reason if I inline the patches they don't >> come through. If I mail to myself only it works just fine. >> > > Actually, I think it should be

Re: [gentoo-dev] [PATCH] glep-0081: prohibit KEYWORDS altering

2019-08-07 Thread Brian Evans
On 8/7/19 11:20 AM, Mikle Kolyada wrote: > Signed-off-by: Mikle Kolyada > --- > As discussed with mgorny at #gentoo-qa > glep-0081.rst | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/glep-0081.rst b/glep-0081.rst > index 082e705..e5a4db2 100644 > --- a/glep-0081.rst > +++ b/glep-0081

[gentoo-dev] [PATCH v2 3/3] savedconfig.eclass: Only check config file candidate once

2019-08-07 Thread Thomas Deutschmann
Due to the injection of $CTARGET and $CHOST in file path we could end up with an already checked config file candidate if $CTARGET or $CHOST isn't used. This commit will make sure that we don't check the same file twice. Signed-off-by: Thomas Deutschmann --- eclass/savedconfig.eclass | 12 +

[gentoo-dev] [PATCH v2 2/3] savedconfig.eclass: Always quote filename in output

2019-08-07 Thread Thomas Deutschmann
Signed-off-by: Thomas Deutschmann --- eclass/savedconfig.eclass | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/eclass/savedconfig.eclass b/eclass/savedconfig.eclass index f62a6055ffdb..1ea464271aff 100644 --- a/eclass/savedconfig.eclass +++ b/eclass/savedconfig.eclass @

[gentoo-dev] [PATCH v2 1/3] savedconfig.eclass: Re-use configuration file scheme

2019-08-07 Thread Thomas Deutschmann
From: Arfrever Frehtes Taifersar Arahesis Make save_config() re-use configuration file scheme used by restore_config(). Fixes: https://bugs.gentoo.org/686348 Signed-off-by: Arfrever Frehtes Taifersar Arahesis Signed-off-by: Thomas Deutschmann --- eclass/savedconfig.eclass | 40 +++

Re: [gentoo-dev] [PATCH 1/3] savedconfig.eclass: Make save_config() re-use configuration file scheme used by restore_config()

2019-08-07 Thread Thomas Deutschmann
On 2019-08-03 18:20, Ulrich Mueller wrote: >> On Sat, 03 Aug 2019, Thomas Deutschmann wrote: > >> +# @ECLASS-VARIABLE: _SAVEDCONFIG_CONFIGURATION_FILE > > 31 chars? Seems excessive for a name of a private variable. And? I'll keep that name for readability instead of finding an abbreviation.

[gentoo-dev] Re: [PATCH 1/3] savedconfig.eclass: Make save_config() re-use configuration file scheme used by restore_config()

2019-08-07 Thread Thomas Deutschmann
On 2019-08-03 15:31, Mike Gilbert wrote: > The summary line on this patch is too long. GLEP 66 states it must be > no longer than 69 characters. v2 will have summary line <=69 characters, thanks. -- Regards, Thomas Deutschmann / Gentoo Linux Developer C4DD 695F A713 8F24 2AA1 5638 5849 7EE5 1D5

Re: [gentoo-dev] [PATCH] glep-0081: prohibit KEYWORDS altering

2019-08-07 Thread Mike Gilbert
On Wed, Aug 7, 2019 at 12:02 PM Kent Fredric wrote: > > On Wed, 07 Aug 2019 17:55:21 +0200 > Ulrich Mueller wrote: > > > Plus, the eclasses explicitly allow KEYWORDS to be overridden by the > > ebuild: > > > > : ${KEYWORDS:=alpha amd64 arm arm64 hppa ia64 m68k ~mips ppc ppc64 ~riscv > > s390 sh

Re: [gentoo-dev] [PATCH] acct-*.eclass: Allow dynamic UID/GID assignment via -1

2019-08-07 Thread Michał Górny
On Wed, 2019-08-07 at 13:29 -0400, Michael Orlitzky wrote: > On 8/7/19 1:10 PM, Michał Górny wrote: > > Using '999' was also suggested (as the first dynamic > > UID/GID) but it would cause issues for people enabling > > ACCT_*_ENFORCE_ID. To avoid this, '-1' does not trigger collision > > checks.

Re: [gentoo-dev] [PATCH] acct-*.eclass: Allow dynamic UID/GID assignment via -1

2019-08-07 Thread Michael Orlitzky
On 8/7/19 1:10 PM, Michał Górny wrote: > > Using '999' was also suggested (as the first dynamic > UID/GID) but it would cause issues for people enabling > ACCT_*_ENFORCE_ID. To avoid this, '-1' does not trigger collision > checks. > Feel free to proceed with this, I'm just curious: what's the p

[gentoo-dev] [PATCH] acct-*.eclass: Allow dynamic UID/GID assignment via -1

2019-08-07 Thread Michał Górny
Allow a special value of '-1' to dynamically assign UID/GID for the user or group. This is intended to be used in overlays where proper assignment does not take place but whose owners wish to switch to acct-* packages. While technically it is possible to choose a free UID/GID, it could be taken a

Re: [gentoo-dev] [PATCH] glep-0081: prohibit KEYWORDS altering

2019-08-07 Thread Kent Fredric
On Wed, 07 Aug 2019 17:55:21 +0200 Ulrich Mueller wrote: > Plus, the eclasses explicitly allow KEYWORDS to be overridden by the > ebuild: > > : ${KEYWORDS:=alpha amd64 arm arm64 hppa ia64 m68k ~mips ppc ppc64 ~riscv > s390 sh sparc x86 ~ppc-aix ~x64-cygwin ~amd64-fbsd ~x86-fbsd ~amd64-linux >

Re: [gentoo-dev] [PATCH] glep-0081: prohibit KEYWORDS altering

2019-08-07 Thread Mikle Kolyada
On 07.08.2019 18:49, Michał Górny wrote: > On Wed, 2019-08-07 at 18:20 +0300, Mikle Kolyada wrote: >> Signed-off-by: Mikle Kolyada >> --- >> As discussed with mgorny at #gentoo-qa >> glep-0081.rst | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/glep-0081.rst b/glep-0081.rst >> ind

Re: [gentoo-dev] [PATCH] glep-0081: prohibit KEYWORDS altering

2019-08-07 Thread Kent Fredric
On Wed, 7 Aug 2019 11:32:43 -0400 Brian Evans wrote: > I object to this as I feel they can incorrect such as on prefix. > > Also, this goes against the established practice of committing directly > to stable. These are exactly the same as virtuals as "they install > nothing" and "just run a scr

Re: [gentoo-dev] [PATCH] glep-0081: prohibit KEYWORDS altering

2019-08-07 Thread Ulrich Mueller
> On Wed, 07 Aug 2019, Mikle Kolyada wrote: > +Both ``acct-group`` and ``acct-user`` eclasses have the ``KEYWORDS`` > +variable predefined, keywords must not be altered locally via ebuilds. > + GLEP 81 doesn't specify anything about the implementation. In fact, it neither requires that it i

Re: [gentoo-dev] [PATCH] glep-0081: prohibit KEYWORDS altering

2019-08-07 Thread Michał Górny
On Wed, 2019-08-07 at 18:20 +0300, Mikle Kolyada wrote: > Signed-off-by: Mikle Kolyada > --- > As discussed with mgorny at #gentoo-qa > glep-0081.rst | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/glep-0081.rst b/glep-0081.rst > index 082e705..e5a4db2 100644 > --- a/glep-0081.rst >

Re: [gentoo-dev] [PATCH] glep-0081: prohibit KEYWORDS altering

2019-08-07 Thread Michał Górny
On Wed, 2019-08-07 at 11:32 -0400, Brian Evans wrote: > On 8/7/2019 11:20 AM, Mikle Kolyada wrote: > > Signed-off-by: Mikle Kolyada > > --- > > As discussed with mgorny at #gentoo-qa > > glep-0081.rst | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/glep-0081.rst b/glep-0081.rst

Re: [gentoo-dev] dynamic groups and users

2019-08-07 Thread Michał Górny
On Tue, 2019-08-06 at 13:41 +0200, Jaco Kroon wrote: > Hi Guys, > > Attaching. It seems for some reason if I inline the patches they don't > come through. If I mail to myself only it works just fine. > Actually, I think it should be changed the other way around. I don't see any reason to pro

Re: [gentoo-dev] [PATCH] glep-0081: prohibit KEYWORDS altering

2019-08-07 Thread Mikle Kolyada
On 07.08.2019 18:32, Brian Evans wrote: > On 8/7/2019 11:20 AM, Mikle Kolyada wrote: >> Signed-off-by: Mikle Kolyada >> --- >> As discussed with mgorny at #gentoo-qa >> glep-0081.rst | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/glep-0081.rst b/glep-0081.rst >> index 082e705..e5

Re: [gentoo-dev] [PATCH 1/2] acct-user/gvm: Add 'gvm' user (UID 495)

2019-08-07 Thread Hasan Calisir
2019-08-07 18:33, Michael Orlitzky yazmış: On 8/7/19 11:30 AM, Hasan ÇALIŞIR wrote: +ACCT_USER_ID=495 +ACCT_USER_HOME=/var/lib/gvm +ACCT_USER_HOME_OWNER=gvm:gvm +ACCT_USER_GROUPS=( gvm ) The HOME_OWNER is redundant, that's the eclass default. Will be fixed in PR. Michael, do i need to r

Re: [gentoo-dev] [PATCH 1/2] acct-user/gvm: Add 'gvm' user (UID 495)

2019-08-07 Thread Michael Orlitzky
On 8/7/19 11:30 AM, Hasan ÇALIŞIR wrote: > +ACCT_USER_ID=495 > +ACCT_USER_HOME=/var/lib/gvm > +ACCT_USER_HOME_OWNER=gvm:gvm > +ACCT_USER_GROUPS=( gvm ) The HOME_OWNER is redundant, that's the eclass default.

Re: [gentoo-dev] [PATCH] glep-0081: prohibit KEYWORDS altering

2019-08-07 Thread Brian Evans
On 8/7/2019 11:20 AM, Mikle Kolyada wrote: > Signed-off-by: Mikle Kolyada > --- > As discussed with mgorny at #gentoo-qa > glep-0081.rst | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/glep-0081.rst b/glep-0081.rst > index 082e705..e5a4db2 100644 > --- a/glep-0081.rst > +++ b/glep-00

[gentoo-dev] [PATCH 0/2] Update-Request for acct-*/gvm (UID-GID 495)

2019-08-07 Thread Hasan ÇALIŞIR
As suggested by Michael Orlitzky, I am updating my previous request for 'gvm' UID-GID_495 with 'nologin' instead of 'bash' shell. PR -> https://github.com/gentoo/gentoo/pull/12609

[gentoo-dev] [PATCH 2/2] acct-group/gvm: Add 'gvm' group (GID 495)

2019-08-07 Thread Hasan ÇALIŞIR
--- acct-group/gvm/gvm-0.ebuild | 10 ++ acct-group/gvm/metadata.xml | 12 2 files changed, 22 insertions(+) create mode 100644 acct-group/gvm/gvm-0.ebuild create mode 100644 acct-group/gvm/metadata.xml diff --git a/acct-group/gvm/gvm-0.ebuild b/acct-group/gvm/gvm-0.ebuild

[gentoo-dev] [PATCH 1/2] acct-user/gvm: Add 'gvm' user (UID 495)

2019-08-07 Thread Hasan ÇALIŞIR
--- acct-user/gvm/gvm-0.ebuild | 14 ++ acct-user/gvm/metadata.xml | 12 2 files changed, 26 insertions(+) create mode 100644 acct-user/gvm/gvm-0.ebuild create mode 100644 acct-user/gvm/metadata.xml diff --git a/acct-user/gvm/gvm-0.ebuild b/acct-user/gvm/gvm-0.ebuild ne

[gentoo-dev] [PATCH] glep-0081: prohibit KEYWORDS altering

2019-08-07 Thread Mikle Kolyada
Signed-off-by: Mikle Kolyada --- As discussed with mgorny at #gentoo-qa glep-0081.rst | 3 +++ 1 file changed, 3 insertions(+) diff --git a/glep-0081.rst b/glep-0081.rst index 082e705..e5a4db2 100644 --- a/glep-0081.rst +++ b/glep-0081.rst @@ -107,6 +107,9 @@ a build time dependency (``DEPEND``)

Re: [gentoo-dev] [PATCH 2/2] acct-user/amavis: new user (UID 333)

2019-08-07 Thread Michael Orlitzky
On 8/3/19 7:49 PM, Michael Orlitzky wrote: > > That makes me think that we should set > > ACCT_USER_HOME=/var/lib/amavis > We'll do this during the next version/revision bump, keeping everything else the same.

[gentoo-dev] [PATCH] ssl-cert.eclass: allow EAPI=7

2019-08-07 Thread Michael Palimaka
--- eclass/ssl-cert.eclass | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/eclass/ssl-cert.eclass b/eclass/ssl-cert.eclass index b5b4250ef22..01783b75848 100644 --- a/eclass/ssl-cert.eclass +++ b/eclass/ssl-cert.eclass @@ -18,7 +18,7 @@ case "${EAPI:-0}" in 0)

[gentoo-dev] RFC: UID/GID assignment for dovenull (74)

2019-08-07 Thread Eray Aslan
I would like to reserve UID/GID 74 for dovenull (net-mail/dovecot). Arch also uses uid 74 for dovenull while Redhat uses next available. -- Eray signature.asc Description: PGP signature

[gentoo-dev] RFC: UID/GID assignment for dovecot (76)

2019-08-07 Thread Eray Aslan
I would like to reserve UID/GID 76 for dovecot (net-mail/dovecot) This id differs from what we have provided historically (97) but gid/97 is used by acct-group/input. So use 76 instead. This id is the same in Arch (76) but differs from Redhat (97). -- Eray signature.asc Description: PGP sig

Re: [gentoo-dev] RFC: UID/GID assignment for dovecot (97)

2019-08-07 Thread Eray Aslan
On Wed, Aug 07, 2019 at 10:59:48AM +0200, Ulrich Mueller wrote: > Historically dovecot came first, but OTOH the ID was added to baselayout > five years ago, and changing baselayout requires some effort. So I'd > suggest to change dovecot. > > The UIDs and GIDs used by Arch might be good: >dove

Re: [gentoo-dev] RFC: UID/GID assignment for dovecot (97)

2019-08-07 Thread Ulrich Mueller
> On Wed, 07 Aug 2019, Eray Aslan wrote: > So do we ask acct-group/input to change their GID? why add an already > used fixed gid to baselayout in the first place (and one that is used on > other distros as well)? whats the thinking here? > or we can change dovecot uid/gid. I dont mind but

Re: [gentoo-dev] RFC: UID/GID assignment for dovecot (97)

2019-08-07 Thread Eray Aslan
On Wed, Aug 07, 2019 at 11:32:48AM +0300, Alexander Tsoy wrote: > В Ср, 07/08/2019 в 09:29 +0300, Eray Aslan пишет: > > I would like to reserve UID/GID 97 for dovecot (net-mail/dovecot) > > This GID is currently used by the input group (sys-apps/baselayout and > acct-group/input). > > https://bug

Re: [gentoo-dev] RFC: UID/GID assignment for dovecot (97)

2019-08-07 Thread Alexander Tsoy
В Ср, 07/08/2019 в 09:29 +0300, Eray Aslan пишет: > I would like to reserve UID/GID 97 for dovecot (net-mail/dovecot) This GID is currently used by the input group (sys-apps/baselayout and acct-group/input). https://bugs.gentoo.org/688390 > > This fixed ID is what we have provided historically

Re: [gentoo-dev] RFC: UID/GID assignment for dovenull (484)

2019-08-07 Thread Ulrich Mueller
> On Wed, 07 Aug 2019, Eray Aslan wrote: > I would like to reserve UID/GID 484 for dovenull (net-mail/dovecot). > Arch uses uid 74 for dovenull while Redhat uses next available. Wouldn't it make sense to keep dovecot and dovenull together, i.e. use 97 for dovecot and 98 for dovenull? (Fedora