Re: File headers for third party utility code

2016-01-05 Thread Todd Lipcon
On Tue, Jan 5, 2016 at 2:39 AM, Steve Loughran wrote: > > One thing to try here is contribute all changes back to the original > author(s), at least as patch submissions, so giving them the option to > incorporate it. > > Sure, I agree that makes sense in the case that you're borrowing someone el

Re: File headers for third party utility code

2016-01-05 Thread Steve Loughran
One thing to try here is contribute all changes back to the original author(s), at least as patch submissions, so giving them the option to incorporate it. The usual benefits of single-source/limited-diff OSS codebases apply, it's good community practise and stops your project unintentionally a

Re: File headers for third party utility code

2016-01-04 Thread Marvin Humphrey
On Mon, Jan 4, 2016 at 3:02 PM, Roman Shaposhnik wrote: > On Mon, Jan 4, 2016 at 2:50 PM, Todd Lipcon wrote: >> Hi all, >> >> I'm working on verifying licenses and copyrights, etc, in Apache Kudu >> (incubating). There is one area I wanted to confirm the right way to >> document in our LICENSE/NO

Re: File headers for third party utility code

2016-01-04 Thread Alex Harui
On 1/4/16, 3:41 PM, "Todd Lipcon" wrote: > >Right, I guess I'm not sure what qualifies minor vs major. In some cases, >we've done trivial edits like putting things in a "kudu" namespace or >removing some portability code. In other cases, we've made more >substantial >alterations to fit our codeb

Re: File headers for third party utility code

2016-01-04 Thread Roman Shaposhnik
On Mon, Jan 4, 2016 at 3:29 PM, Alex Harui wrote: > > > On 1/4/16, 3:02 PM, "shaposh...@gmail.com on behalf of Roman Shaposhnik" > wrote: >> >>> 2) In the cases that we've made non-trivial changes to the source, we >>> should additionally add the ASF copyright notice at the top of the file, >>> a

Re: File headers for third party utility code

2016-01-04 Thread Todd Lipcon
On Mon, Jan 4, 2016 at 3:29 PM, Alex Harui wrote: > > > On 1/4/16, 3:02 PM, "shaposh...@gmail.com on behalf of Roman Shaposhnik" > wrote: > > > >> 2) In the cases that we've made non-trivial changes to the source, we > >> should additionally add the ASF copyright notice at the top of the file, >

Re: File headers for third party utility code

2016-01-04 Thread Alex Harui
On 1/4/16, 3:02 PM, "shaposh...@gmail.com on behalf of Roman Shaposhnik" wrote: > >> 2) In the cases that we've made non-trivial changes to the source, we >> should additionally add the ASF copyright notice at the top of the file, >> and amend the original copyright statement with the words "Som

Re: File headers for third party utility code

2016-01-04 Thread Roman Shaposhnik
On Mon, Jan 4, 2016 at 2:50 PM, Todd Lipcon wrote: > Hi all, > > I'm working on verifying licenses and copyrights, etc, in Apache Kudu > (incubating). There is one area I wanted to confirm the right way to > document in our LICENSE/NOTICE files: > > Kudu makes use of a lot of open source utility c