Re: [VOTE]: Release Apache RocketMQ 4.0.0(incubating) (RC3)

2017-02-17 Thread Justin Mclean
Hi, > Note things like the broad copyright dates. Yep agreed that’s more than a bit silly. We’ll see what we can do to fix that. > Any plans to reach out to get it corrected, or try to upgrade if they > already fixed? We can ask. If a change was made BTW that would effect a number of other pro

Re: [VOTE]: Release Apache RocketMQ 4.0.0(incubating) (RC3)

2017-02-17 Thread John D. Ament
Justin, On Thu, Feb 16, 2017 at 7:45 PM Justin Mclean wrote: > Hi, > > > - README points to "rocketmq community" as a github page > > Yes they are aware this is an issue. > > > - fastjson (missing NOTICE) > > Why is this an issue? Fastjson is mentioned in LICENSE and the 3rd party > repo contain

Re: [VOTE]: Release Apache RocketMQ 4.0.0(incubating) (RC3)

2017-02-16 Thread Von Gosling
> IMO it best to follow current documentation than copy what other projects may > of done. Agreed. That’s why i hope some clear official documentation to be polished, rather than scatter in every apache project :-) BTW, in order to help our guys, we also arrange 2 articles in website about ap

Re: [VOTE]: Release Apache RocketMQ 4.0.0(incubating) (RC3)

2017-02-16 Thread Justin Mclean
Hi, > I also want to know the correct distribution about NOTICE and LICENSE. also > including the LICENSE and LICENSE-BIN(why we must list the 2 different > license files when in source and bundle).. As explained on the dev list you need different NOTICE and LICENSE files because their content

Re: [VOTE]: Release Apache RocketMQ 4.0.0(incubating) (RC3)

2017-02-16 Thread Von Gosling
I also want to know the correct distribution about NOTICE and LICENSE. also including the LICENSE and LICENSE-BIN(why we must list the 2 different license files when in source and bundle. it seems to different in many apache projects .we are confused when refering these projects ) IMO, if have

Re: [VOTE]: Release Apache RocketMQ 4.0.0(incubating) (RC3)

2017-02-16 Thread Justin Mclean
Hi, > - README points to "rocketmq community" as a github page Yes they are aware this is an issue. > - fastjson (missing NOTICE) Why is this an issue? Fastjson is mentioned in LICENSE and the 3rd party repo contains no NOTICE file (which is rather common sadly). > - commons-cli (missing NOTI

Re: [VOTE]: Release Apache RocketMQ 4.0.0(incubating) (RC3)

2017-02-16 Thread John D. Ament
On Thu, Feb 16, 2017 at 12:32 PM Bruce Snyder wrote: > +1 (binding) > > No showstopper issues found, only minor issues that will be ironed out in > subsequent releases (e.g., README needs some cleanup, need consistency in > artifact naming). > Do you have a full list of those issues? Here's pro

Re: [VOTE]: Release Apache RocketMQ 4.0.0(incubating) (RC3)

2017-02-16 Thread Bruce Snyder
+1 (binding) No showstopper issues found, only minor issues that will be ironed out in subsequent releases (e.g., README needs some cleanup, need consistency in artifact naming). Bruce On Wed, Feb 15, 2017 at 10:46 PM, yukon wrote: > Hello Incubator PMC, > > The Apache RocketMQ community has v