Re: [Ftpserver] Comments on the new code

2005-10-03 Thread Craig Russell
Hi,I enthusiastically endorse Paul's comment that you should be agnostic as to which DI framework is used with FtpServer.What might be more practical is for you to ship sample code that shows users of Pico, Spring, etc. how to configure your FtpServer component using their metadata specifications.

Re: [Ftpserver] Comments on the new code

2005-10-02 Thread Enrique Rodriguez
On 10/2/05, Niclas Hedhman <[EMAIL PROTECTED]> wrote: ... > Now, Noel's suggestion for OSGi as the runtime platform is interesting, if for > no other reason than it allows for hot deploy and reloads. But I think it > would be possible to provide a BundleActivator and register the service(s) > even

Re: [Ftpserver] Comments on the new code

2005-10-02 Thread Paul Hammant
IMHO, the basic design and implementation should be XML free and provide a straight forward API for assembly, configuration (preferably atomic) and the other stuff. Any runtime platform support can be added on top of that. Look at Jetty for an example of this approach. Now, Noel's suggest

Re: [Ftpserver] Comments on the new code

2005-10-02 Thread Paul Hammant
You should aim to ship with neither Spring nor PicoContainer. It is perfectly possible to construct a set of DI components that comprise FtpServer and in a main method do : Foo foo = new Foo(); Bar bar = new Bar(foo); Apple apple = new Apple(); apple.setFoo(foo); apple.setBar(bar);

Re: [Ftpserver] Comments on the new code

2005-10-01 Thread Niclas Hedhman
On Sunday 02 October 2005 06:52, Niklas Gustavsson wrote: > Paul Hammant wrote: > > OK, if we're keen about Dependency Injection, we'd need to change a > > lot. The basic FtpConfig component should have little knowledge of > > UserManager (and others), and no coupling to it... > > If we do aim for

RE: [Ftpserver] Comments on the new code

2005-10-01 Thread Noel J. Bergman
Actually, I think that perhaps we might want to look at OSGi, and supporting FTPserver as an OSGi bundle. --- Noel - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]

Re: [Ftpserver] Comments on the new code

2005-10-01 Thread Niklas Gustavsson
Paul Hammant wrote: OK, if we're keen about Dependency Injection, we'd need to change a lot. The basic FtpConfig component should have little knowledge of UserManager (and others), and no coupling to it... If we do aim for a DI/IoC approach (and I think we should), should we choose a DI im

Re: [Ftpserver] Comments on the new code

2005-10-01 Thread Niklas Gustavsson
Paul Hammant wrote: OK, if we're keen about Dependency Injection, we'd need to change a lot. The basic FtpConfig component should have little knowledge of UserManager (and others), and no coupling to it... If we do aim for a DI/IoC approach (and I think we should), should we choose a DI

Re: [Ftpserver] Comments on the new code

2005-09-22 Thread Paul Hammant
The package ftplet is the basic API required to add custom user specified ftplets. The server needs slightly modified version of these APIs. Ftplet API is somewhat fixed but server API may get changed in future. This is the reason behind this difference. The following two hierarchy will clarify

Re: [Ftpserver] Comments on the new code

2005-09-20 Thread Rana Bhattacharyya
The package ftplet is the basic API required to add custom user specified ftplets. The server needs slightly modified version of these APIs. Ftplet API is somewhat fixed but server API may get changed in future. This is the reason behind this difference. The following two hierarchy will clarify th

Re: [Ftpserver] Comments on the new code

2005-09-19 Thread Niklas Gustavsson
Hi why is this difference necessary? Or maybe rather, why the need for the I-prefix on the "internal" interfaces? /niklas /niklas Rana Bhattacharyya wrote: > Hi, > > This is the logic behind the interface name. > > 1. ftplet is basic interface package which will be > exposed to add custom

Re: [Ftpserver] Comments on the new code

2005-09-19 Thread Rana Bhattacharyya
Hi, This is the logic behind the interface name. 1. ftplet is basic interface package which will be exposed to add custom ftplet. 2. The package interfaces has all the other interfaces used in the server. Here all the observers will not have I in front. Everything else will have I in front.

[Ftpserver] Comments on the new code

2005-09-18 Thread Niklas Gustavsson
Hi I've taken a quick look through the new code for Ftpserver commited by Rana. For the most of it I'm impressed and think it looks very good. I do have some minor comments though: 1. Interfaces are inconsitently named, some starting with "I", some not. They are also somewhat randomly placed in