Re: [VOTE] Release Apache Polaris 0.10.0-beta-incubating (rc2)

2025-05-11 Thread Jean-Baptiste Onofré
Hi I think all bundled dependencies are documented. About the comment regarding BSD/MIT, let me check, we do things similar to other ASF projects here. Thanks ! Regards JB On Mon, May 12, 2025 at 6:29 AM Justin Mclean wrote: > > Hi, > > > Good catch for DISCLAIMER, I forgot to include it, I wi

Re: [VOTE] Release Apache Polaris 0.10.0-beta-incubating (rc2)

2025-05-11 Thread Jean-Baptiste Onofré
Thanks, let me do a pass (with the committers who added these files). On Mon, May 12, 2025 at 6:19 AM Justin Mclean wrote: > > Hi, > > > A few files you mention are not pure code copied, it's probably inspired > > but not full copy. > > Other files were "inspired by” or changed significantly or

Re: [VOTE] Release Apache Polaris 0.10.0-beta-incubating (rc2)

2025-05-11 Thread Justin Mclean
Hi, > Good catch for DISCLAIMER, I forgot to include it, I will do it. Does > it mean that all jar files should include DISCLAIMER (not sure > podlings are doing that) ? I don't think it needs to be included in all jar files, but there no harm if you do that. > For LICENSE and NOTICE, it's a mi

Re: [VOTE] Release Apache Polaris 0.10.0-beta-incubating (rc2)

2025-05-11 Thread Justin Mclean
Hi, > A few files you mention are not pure code copied, it's probably inspired but > not full copy. Other files were "inspired by” or changed significantly or were simple, so I didn't list them. For those files, it was between 60% and 95% copied. Kind Regards, Justin --

Re: [VOTE] Release Apache Polaris 0.10.0-beta-incubating (rc2)

2025-05-11 Thread Jean-Baptiste Onofré
Hi Good catch for DISCLAIMER, I forgot to include it, I will do it. Does it mean that all jar files should include DISCLAIMER (not sure podlings are doing that) ? For LICENSE and NOTICE, it's a mix: I have a script to o a first pass (only LICENSE), then I did a manual pass and the NOTICE manually

Re: [VOTE] Release Apache Polaris 0.10.0-beta-incubating (rc2)

2025-05-11 Thread Jean-Baptiste Onofré
Hi A few files you mention are not pure code copied, it's probably inspired but not full copy. I will do a new pass. Thanks ! Regards JB On Mon, May 12, 2025 at 1:29 AM Justin Mclean wrote: > > Hi, > > It looks like a few more third-party files not mentioned in the LICENSE may > also have inco

[jira] [Created] (INCUBATOR-288) svn clone of incubator repo takes > 12 hours

2025-05-11 Thread Jordan West (Jira)
Jordan West created INCUBATOR-288: - Summary: svn clone of incubator repo takes > 12 hours Key: INCUBATOR-288 URL: https://issues.apache.org/jira/browse/INCUBATOR-288 Project: Incubator Issue

Re: [VOTE] Release Apache Polaris 0.10.0-beta-incubating (rc2)

2025-05-11 Thread justin
Hi, I looked at the two binary releases, and while I didn't check everything, I did notice they are missing the incubator DISCLAIMER. The LICENSE and NOTICE files seem to be auto-generated; in my previous experience, this almost always introduces errors. For example, the LICENSE files are incor

Re: [VOTE] Release Apache Polaris 0.10.0-beta-incubating (rc2)

2025-05-11 Thread Justin Mclean
Hi, It looks like a few more third-party files not mentioned in the LICENSE may also have incorrect headers. Looks like these files are from Nessie: ./build-logic/src/main/kotlin/copiedcode/CopiedCodeCheckerPlugin.kt ./build-logic/src/main/kotlin/copiedcode/CopiedCodeCheckerExtension.kt ./build-

Re: [VOTE] Release Apache Polaris 0.10.0-beta-incubating (rc2)

2025-05-11 Thread Jean-Baptiste Onofré
Thanks for your reply. It’s also my understanding and what I applied initially. I’m doing the changes. Thanks ! Regards JB Le dim. 11 mai 2025 à 12:02, Justin Mclean a écrit : > Hi, > > > Do you think what's provided in > > https://issues.apache.org/jira/browse/LEGAL-684 is accurate/complete

Re: [VOTE] Release Apache Polaris 0.10.0-beta-incubating (rc2)

2025-05-11 Thread Justin Mclean
Hi, > Do you think what's provided in > https://issues.apache.org/jira/browse/LEGAL-684 is accurate/complete ? Yes, and it follows the advice in [1] > Specifically, as the how-to states: "Do not add anything to NOTICE > which is not legally required." So, if those dependencies have > third-party