Re: [VOTE] Release Apache Seata (Incubating) v2.1.0-RC4

2024-07-06 Thread Paul King
Others have commented on the release. Just a quick comment on the following wording: "The vote will be open for at least 72 hours or until necessary number of votes are reached." In general, you cannot close the vote early. Some -1 votes may come in after some +1 votes. The idea of the 72 hours is

Re: [VOTE] Release Apache Seata (Incubating) v2.1.0-RC4

2024-07-06 Thread tison
> * seata-server/templates/_helpers.tpl [5] is a copy of a file in > github.com/open-hand/hzero-starter-parent/ - this should be mentioned > in your LICENSE unless the file in > github.com/open-hand/hzero-starter-parent/ is a copy of your file I found that the seata's file comes from 5 years ago w

Re: [VOTE] Release Apache Seata (Incubating) v2.1.0-RC4

2024-07-06 Thread tison
> * as an example, with 'CDDL-1.0 and GPL-2.0' [4], you should state > that you choose CDDL-1.0 because GPL-2.0 is not allowed This is an interesting point. I suppose those NOTICE / LICENSE of binary are generated by some maven plugins, or at least there are a few of ASF projects doing so. Then

Re: [VOTE] Release Apache Seata (Incubating) v2.1.0-RC4

2024-07-06 Thread PJ Fanning
There are a number of other MIT licensed files in your console/src/main/resources/static folder and subfolders. CSS and Javascript files. All need to be mentioned in your LICENSE file. On Sat, 6 Jul 2024 at 20:00, PJ Fanning wrote: > > -1 (binding) from me > > * You have MIT Licensed code but no

Re: [VOTE] Release Apache Seata (Incubating) v2.1.0-RC4

2024-07-06 Thread PJ Fanning
-1 (binding) from me * You have MIT Licensed code but no mention of it in your LICENSE [1]. One example [2] but there is another g4 file with the same header. * The LICENSE mentions BSD LIcense for Antlr and maybe this relates to these MIT Licensed files but this isn't clear * there is another MIT

Re: [VOTE] Release Apache Seata (Incubating) v2.1.0-RC4

2024-07-06 Thread PJ Fanning
I think it would be better to put RC4 in the directory name of the release dir. https://dist.apache.org/repos/dist/dev/incubator/seata/incubator-seata/2.1.0/ should be https://dist.apache.org/repos/dist/dev/incubator/seata/incubator-seata/2.1.0-RC4/ or even https://dist.apache.org/repos/dist/dev/i

Re: [VOTE] Release Apache Seata (Incubating) v2.1.0-RC4

2024-07-06 Thread tison
No. I think it's fine to improve in the following release. But if you'd like to make a new RC, it's of course OK. Best, tison. Min Ji 于2024年7月6日周六 09:49写道: > Hi tison, > > Thank you very much for your suggestion. I have learned a lot from > your suggestion. Does changing the compressed directo

Re: [VOTE] Release Apache Seata (Incubating) v2.1.0-RC4

2024-07-06 Thread Min Ji
Hi tison, Thank you very much for your suggestion. I have learned a lot from your suggestion. Does changing the compressed directory name mean I need to initiate a new round of voting? If so, I hope we can make the correction in the next RC release. Warm regards, Ji Min tison 于2024年7月6日周六 01:

Re: [VOTE] Release Apache Seata (Incubating) v2.1.0-RC4

2024-07-06 Thread Min Ji
Hi tison, Thanks for your review. > I cannot build from source on osx_aarch64 due to: > > [ERROR] Failed to execute goal > org.xolstice.maven.plugins:protobuf-maven-plugin:0.6.1:compile (default) on > project seata-serializer-protobuf: Unable to resolve artifact: Missing: > [ERROR] -- > [

Re: [VOTE] Release Apache Seata (Incubating) v2.1.0-RC4

2024-07-06 Thread Min Ji
Thanks to Tison and PJ Fanning for your feedback on the signing key location issue. Due to some misunderstandings of the release process, the KEY was uploaded to the wrong location. I have now updated the KEY, and you can find the signed key at the following location. https://downloads.apache.org/

Re: [VOTE] Release Apache Seata (Incubating) v2.1.0-RC4

2024-07-06 Thread PJ Fanning
Min Ji - could you upload the KEYS file to the right place? I, personally, am not going to vote +1 when the KEYS file is not in the right place. On Fri, 5 Jul 2024 at 18:14, tison wrote: > > BTW, the unpacked folders name: > > apache-seata-2.1.0-incubating-src.zip -> incubator-seata-2.1.0 > apach