+1 (non-binding)
Kindly remind to verify this RC. I'd like to conclude this voting tomorrow.
Best,
Jingsong
On Tue, Jun 6, 2023 at 12:53 PM Yu Li wrote:
>
> +1 (binding)
>
> - Checked release file name and location: *OK*
>
> - Checked sum and signatures: *OK*
>
> - Checked DISCLAIMER file exist
+1 (binding)
- Checked release file name and location: *OK*
- Checked sum and signatures: *OK*
- Checked DISCLAIMER file exists: *OK*
- Checked LICENSE and NOTICE files: *OK*
* Issues found in previous review resolved: *OK*
* License of 3rd-party code contained correctly mentioned in LI
+1 binding
I checked ：
- Download links are valid.
- Checksums and signatures is good to me.
- I can build the binary from the source code.
- All source files have ASF headers
Best wishes!
Yu Xiao
ASF Member
Apache IPMC Member.
Jeff Zhang 于2023年6月5日周一 22:14写道：
>
>
> +1 (binding)
>
> On 2023
> This image includes a vendor logo, I don't think the ASF is granted to
> use that as a part of distribution.
Thank you for pointing that out! I have submitted a pull request to remove it
from our release script.
On Mon, Jun 5, 2023, at 22:26, Sheng Wu wrote:
> Hi
>
> -1 binding
>
> 1. (The res
> I don't think we follow the policy or the rule.
Then it's your personal preference to ask for something extra.
This can be tried address but not a valid -1 reason.
If you agree that it's not a -1 reason, we may go into what you propose:
OpenDAL once added some materials about LICENSE on binary
tison 于2023年6月5日周一 22:36写道：
>
> > 2. Meanwhile, why the website is a part of source release?
>
> I suggest we can exclude website materials from the source release
>
> > Where is the LICENSE and NOTICE of the binary
>
> If we don't make binary releases, what is the policy for bundle their
> LICENS
> 2. Meanwhile, why the website is a part of source release?
I suggest we can exclude website materials from the source release
> Where is the LICENSE and NOTICE of the binary
If we don't make binary releases, what is the policy for bundle their
LICENSE or NOTICE?
Justin commented the last time
Hi
-1 binding
1. (The resonse of -1) Unexpected images showing up
> website/blog/2023-03-16-opendal-entered-apache-incubator/opendal-entered-apache.png
This image includes a vendor logo, I don't think the ASF is granted to
use that as a part of distribution.
2. Meanwhile, why the website is a pa
Hello everyone,
Thanks for your review and vote for "Release Apache OpenDAL (Incubating)
v0.36.0-rc.1"
I'm happy to announce the vote has passed:
3 binding votes and 3 non-binding votes, no +0 or -1 votes.
Thanks for reviewing and voting.
+3 (binding) +1, from:
- tison
- Xiaoqiao He
- Willem
+1 (binding)
On 2023/06/05 14:00:21 Willem Jiang wrote:
> +1 (binding)
> Here is what I checked:
> - Download links are valid.
> - The checksums and signatures are validated.
> - The LICENSE and NOTICE files look good to me.
> - There is a DISCLAIMER file about incubating.
> - No binary files i
+1. Here is what I checked:
- The checksums and signatures are validated.
- The LICENSE and NOTICE files look good to me.
- There is a DISCLAIMER file about incubating.
- No binary files in the source release
- I can build the binary from the source kit.
Willem Jiang
Twitter: willemjiang
Weibo: 姜
+1 (binding)
Here is what I checked:
- Download links are valid.
- The checksums and signatures are validated.
- The LICENSE and NOTICE files look good to me.
- There is a DISCLAIMER file about incubating.
- No binary files in the source release
- I can build the binary from the source kit.
Wille
> NOTE: README.md does not include `how to build.`
Thanks for your NOTE! We have included the instructions on how to build in our
Contributing Guide. We will ensure that this is made clearer in future updates.
On Mon, Jun 5, 2023, at 21:41, Xiaoqiao He wrote:
> +1(binding)
>
> [x] Download links
+1(binding)
[x] Download links are valid.
[x] Checksums and PGP signatures are valid.
[x] LICENSE files exist.
[x] NOTICE is included.
[x] DISCLAIMER is included.
[x] Source code artifacts have correct names matching the current release.
[x] All source files have license headers if necessary.
[x]
+1, non-binding, after checking:
[ ✓] Download links are valid.
[ ✓] Checksums and signatures.
[ ✓] LICENSE/NOTICE files exist
[ ✓] No unexpected binary files
[ ✓] All source files have ASF headers, except those from other projects such
as JavaLexer.g4
Kent
On 2023/05/29 03:47:31 Jingsong Li
15 matches
Mail list logo
