Re: [VOTE] Release Apache OpenDAL(incubating) 0.34.0-rc1

2023-05-21 Thread Justin Mclean
Hi, Sorry, but it -1 binding from me, LICENSE and NOTICE need to be corrected and the lease artefacts need incubating in the name. I checked: - “incubating" is not in the release name - signatures and hash are fine - LICENSE and NOTICE are not correct, LICENSE information goes in LICENSE not NO

Re: [VOTE] Release Apache Teaclave (incubating) v0.5.1-rc.1

2023-05-21 Thread Justin Mclean
Hi, > I opened an issue in https://github.com/dermesser/leveldb-rs/issues/26. > The auther confirmed the original and gave some explanation about the > different license. In general if something is ported to anther language it keeps the same license. It this case both licenses are compatible wi

Re: [VOTE] Release Apache Paimon(incubating) 0.4.0-incubating rc5

2023-05-21 Thread justin
Hi, There are many different versions of the maven wrapper, both before and after it was donated to the ASF. However the ASF version does need to be mentioned in LICENSE [1] and NOTICE [2]. Kind Regards, Justin 1. https://infra.apache.org/licensing-howto.html#alv2-dep 2. https://github.com/apa

Re: [VOTE] Release Apache Paimon(incubating) 0.4.0-incubating rc5

2023-05-21 Thread Justin Mclean
Hi, Sorry but it's -1 (binding) from me as LICENSE and NOTICE need a little more work and quite a few sure files are missing ASF headers. I checked: - incubating in name - signature and hash are fine (Although you might want to consider changing your apache id, it's signed with lzljs3620...@apa

Re: Re: [VOTE] Release Apache Paimon(incubating) 0.4.0-incubating rc5

2023-05-21 Thread li gang
Hi Jingsong, The Maven Wrapper is a source dependency, so you need to add it to the source license file. Maybe each ASF project choose a different version of Maven Wrapper, and not all versions of Maven Wrapper has the NOTICE file. Jingsong Li 于2023年5月19日周五 10:17写道: > Thanks all for your voting