Sorry guys, but I found a critical issue thus another -1 (binding)
* The source package contains a licenses-binary directory, which has
un-included dependency licenses (for source). Please check the packaging
script and confirm whether there is any error in it (the name of "licenses-
*binary*" ind
It depends, if you wrote the codes of `AssertUtils.scala` from scratch without
referencing
the Spring's Assert class, you can definitely said it's your own work and your
own IP,
but if you copied the content from Spring's, and converted it into Scala, even
with some modifications,
I still consid
Thanks for your review and feedback, we will fix this issue, but I
have a question:
As we all know, spring is developed in java language, while
Streampark's AssertUtils.scala[1] is developed in scala. As you can
see, the methods and logic in it are very simple. Even if the logic
and method names i
+1 (binding)
I checked :
- [X] Download links are valid.
- [X] signatures and hashes are ok.
- [X] No binary files
- [X] LICENSE and NOTICE are ok
- [X] incubating in name, all source files have ASF headers.
Regards
Liang
On 2023/02/13 02:41:51 hulk wrote:
> +1 (non-binding)
>
> I checked:
>
Hi, -1 (binding), you cannot change the license header of a third-party's
file[1] as you mentioned in LICENSE it's from Spring team[2].
[1]
streampark-common/src/main/scala/org/apache/streampark/common/util/AssertUtils.scala
[2] https://github.com/spring-projects/spring-framework
> On Feb 10, 2
+1 (binding)
Good luck.
Eason Chen 于2023年2月10日周五 10:32写道：
> Dear Apache Incubator Community and IPMC members,
>
> After having the graduation discussion in the EventMesh community [1],
> we passed the vote within the EventMesh community [2] and the vote
> result was published[3].
> We then discu
hi Kent Yao:
The current download page[1] is just a template, all links are empty links,
and there is no content about the release of version 2.0,
The previously failed RCs users will download and use. so deleted, I
don't konw if this will be the reason for block the release.
[1] https://stream
+1 non-binding.
Good luck.
Xin Wang 于2023年2月13日周一 11:17写道：
> +1
>
> Jerry Tan 于2023年2月13日周一 10:48写道：
>
> > +1.
> > Good luck and best regards.
> >
> > On Mon, Feb 13, 2023 at 10:28 AM xiong mengfei
> > wrote:
> >
> > > +1
> > >
> > > On Mon, Feb 13, 2023 at 10:22 AM sanchen wrote:
> > >
> > >
+1 (non-binding):
I checked:
1. All download links are valid
2.The source and distribution packages already exist
3. Checksum and signature are OK
4. LICENSE and NOTICE are exist and NOTICE file year is ok
5. Build successfully on ubuntu22.04
Kent Yao 于2023年2月13日周一 11:46写道：
Hi
(-1, non-binding): There is a spoiler for 2.0.0 on your download page[1], you
shall remove it as it's not been approved yet.
The previously failed RCs, e.g. [2] have been deleted, which makes it difficult
for others to
track the history of the 2.0.0 voting progress.
Kent Yao
[1] https://s
+1
Jerry Tan 于2023年2月13日周一 10:48写道：
> +1.
> Good luck and best regards.
>
> On Mon, Feb 13, 2023 at 10:28 AM xiong mengfei
> wrote:
>
> > +1
> >
> > On Mon, Feb 13, 2023 at 10:22 AM sanchen wrote:
> >
> > > +1
> > >
> > >
> > > >
> > > > On 2023/02/10 02:31:56 Eason Chen wrote:
> > > > > Dear
+1 (non-binding):
I checked:
1. All download links are valid
2.The source and distribution packages already exist
3. Checksum and signature are OK
4. LICENSE and NOTICE are exist and NOTICE file year is ok
5. Build successfully on ubuntu22.04
Huajie Wang 于2023年2月10日周五 17:46写道
+1.
Good luck and best regards.
On Mon, Feb 13, 2023 at 10:28 AM xiong mengfei wrote:
> +1
>
> On Mon, Feb 13, 2023 at 10:22 AM sanchen wrote:
>
> > +1
> >
> >
> > >
> > > On 2023/02/10 02:31:56 Eason Chen wrote:
> > > > Dear Apache Incubator Community and IPMC members,
> > > >
> > > > After ha
+1 (non-binding)
I checked:
[x] Download links are valid.
[x] Checksums and signatures.
[x] LICENSE/NOTICE files exist
[x] No unexpected binary files
[x] All source files have ASF headers
[x] Can compile from source
[x] All Tests Passed
[x] Docker image with right v
+1 (binding).
- Download links are valid.
- Checksums and signatures are valid.
- LICENSE, NOTICE and DISCLAIMER files exist.
- All source files have apache license declare if necessary.
- Compile from source passed.
- No compiled archives bundled in the source archive.
- Run successfully simple c
+1
On Mon, Feb 13, 2023 at 10:22 AM sanchen wrote:
> +1
>
>
> >
> > On 2023/02/10 02:31:56 Eason Chen wrote:
> > > Dear Apache Incubator Community and IPMC members,
> > >
> > > After having the graduation discussion in the EventMesh community [1],
> > > we passed the vote within the EventMesh co
+1
Eason Chen 于2023年2月10日周五 10:32写道：
> Dear Apache Incubator Community and IPMC members,
>
> After having the graduation discussion in the EventMesh community [1],
> we passed the vote within the EventMesh community [2] and the vote
> result was published[3].
> We then discussed the graduation f
+1
>
> On 2023/02/10 02:31:56 Eason Chen wrote:
> > Dear Apache Incubator Community and IPMC members,
> >
> > After having the graduation discussion in the EventMesh community [1],
> > we passed the vote within the EventMesh community [2] and the vote
> > result was published[3].
> > We then disc
+1
On 2023/02/10 02:31:56 Eason Chen wrote:
> Dear Apache Incubator Community and IPMC members,
>
> After having the graduation discussion in the EventMesh community [1],
> we passed the vote within the EventMesh community [2] and the vote
> result was published[3].
> We then discussed the gradu
+1, congratulations.
Best,
Huajie Wang
wenjun 于2023年2月13日周一 10:04写道：
> +1 (non-binding)
>
> Great to join EventMesh community.
>
>
>
> On Mon, Feb 13, 2023 at 9:59 AM ShannonDing wrote:
>
> > +1
> >
> > At 2023-02-10 10:31:56, "Eason Chen" wrote:
> > >Dear Apache Incubator Community and I
+1 (non-binding)
--
Zhang Yonglun
Apache ShenYu & ShardingSphere
Eason Chen 于2023年2月10日周五 10:32写道：
>
> Dear Apache Incubator Community and IPMC members,
>
> After having the graduation discussion in the EventMesh community [1],
> we passed the vote within the EventMesh community [2] and the vot
+1 (non-binding)
Great to join EventMesh community.
On Mon, Feb 13, 2023 at 9:59 AM ShannonDing wrote:
> +1
>
> At 2023-02-10 10:31:56, "Eason Chen" wrote:
> >Dear Apache Incubator Community and IPMC members,
> >
> >After having the graduation discussion in the EventMesh community [1],
> >we
+1
At 2023-02-10 10:31:56, "Eason Chen" wrote:
>Dear Apache Incubator Community and IPMC members,
>
>After having the graduation discussion in the EventMesh community [1],
>we passed the vote within the EventMesh community [2] and the vote
>result was published[3].
>We then discussed the graduati
+1
On 2023/02/10 02:31:56 Eason Chen wrote:
> Dear Apache Incubator Community and IPMC members,
>
> After having the graduation discussion in the EventMesh community [1],
> we passed the vote within the EventMesh community [2] and the vote
> result was published[3].
> We then discussed the gradua
+1
Willem Jiang 于2023年2月13日周一 08:47写道：
> +1 （binding）
> It's great to see EventMesh in good shape for graduation.
>
> Willem Jiang
>
> Twitter: willemjiang
> Weibo: 姜宁willem
>
> On Fri, Feb 10, 2023 at 10:32 AM Eason Chen
> wrote:
> >
> > Dear Apache Incubator Community and IPMC members,
> >
>
+1 （binding）
It's great to see EventMesh in good shape for graduation.
Willem Jiang
Twitter: willemjiang
Weibo: 姜宁willem
On Fri, Feb 10, 2023 at 10:32 AM Eason Chen wrote:
>
> Dear Apache Incubator Community and IPMC members,
>
> After having the graduation discussion in the EventMesh community
+1 (binding)
Verified:
- [X] Download links are valid.
- [X] Checksums and PGP signatures are valid.
- [X] Source code artifacts have correct names matching the current release.
- [X] LICENSE, NOTICE and DISCLAIMER are correct for the repository.
- [X] All files have license headers if necessary.
Hi,
+1 (non-binding) from me. I have checked:
1. All the above links are correct;
2. The signature and checksum are correct;
3. LICENSE and NOTICE files exist;
Best regards
Chao Zhang
https://github.com/tokers
On Sat, Feb 11, 2023 at 10:44 PM Myth wrote:
>
> Hello Incubator PMC,
>
> The Apach
28 matches
Mail list logo
