Hi Gang Li,
Thanks for your vote, we will fix the issues you raised.
li gang 于2023年1月28日周六 23:41写道：
>
> +1 (binding)
> I checked
> - All files have license header if necessary.
> - LICENSE and NOTICE files exist
> - Include the word incubating in the release file name.
> - DISCLAIMER-WIP file ex
+1 (binding)
I checked
- All files have license header if necessary.
- LICENSE and NOTICE files exist
- Include the word incubating in the release file name.
- DISCLAIMER-WIP file exist
- Signatures are fine
Three are two issues need to be fixed next release.
1、There are a lot of duplicated line o
Thanks for review and feedback, streampark project does included the source
code of the maven-wrapper project,
We will add the license information of maven-wrapper to LICENSE file.
Best,
Huajie Wang
kezhenxu94 于2023年1月28日周六 22:15写道：
>
> > On Jan 28, 2023, at 21:43, Justin Mclean
> wrote:
>
+1, I have checked:
[√] Download links are valid. [√] Checksums and PGP signatures are valid. [√]
DISCLAIMER is included. [√] Source code artifacts have correct names matching
the current release. [√] LICENSE and NOTICE files are correct for each
EventMesh repo. [√] All files have license he
> On Jan 28, 2023, at 21:43, Justin Mclean wrote:
>
> Hi,
>
>> 2. NOTICE is OK but I’m not sure if the maven wrapper code is included in
>> the source release?
>>
>> the maven wrapper code is not included in the source code[1]
But I can see the maven wrapper scripts are included in the sourc
On Sat, Jan 28, 2023 at 9:52 PM Huajie Wang wrote:
>
> Hi Justin:
>
> Thanks for your feedback, it is really redundant to mention in the NOTICE
> file, We will fix it.
I checked the source package and I'm pretty sure your mvnw.cmd and
mvnw files are sourced from the maven-wrapper project.
>
>
> Ju
Hi Justin:
Thanks for your feedback, it is really redundant to mention in the NOTICE
file, We will fix it.
Justin Mclean 于2023年1月28日周六 21:44写道：
> Hi,
>
> > 2. NOTICE is OK but I’m not sure if the maven wrapper code is included in
> > the source release?
> >
> > the maven wrapper code is not in
Hi,
> 2. NOTICE is OK but I’m not sure if the maven wrapper code is included in
> the source release?
>
> the maven wrapper code is not included in the source code[1]
Then why is it mention in the NOTICE file?
Kind Regards,
Justin
---
Hello Incubator Community:
I'm cancelling this vote:
https://lists.apache.org/thread/f8jqzbqvhnwn6y8gf9yov1ox9oz4797v
because of license issues. I'll fix them and start the round 3 vote process.
There are some License related issues we need to fixed:
1. remove google-fonts from the front-end
Hi Justin,
Thanks for your review, we'll fix the problems you mentioned.
We need to fix some license related issues:
1. LICENSE is missing license information for fonts under
we'll remove google-fonts from the front-end module,
2. NOTICE is OK but I’m not sure if the maven wrapper code is inc
>
> Hi Justin,
>
> Thanks for your review, we'll fix the problems you mentioned.
>
> We need to fix some license related issues:
>
> 1. LICENSE is missing license information for fonts under
>
> We'll remove google-fonts from the front-end module,
>
>
> 2. NOTICE is OK but I’m not sure if the maven
Hi,
Sorry I’it -1 binding from me.
I checked in the source release:
- incubating in name
- signatures and hashes are fine
- LICENSE is missing license information for fonts under [1]. It looks like
this is this font [2] licensed under the Open Font License a category B
license. [3] Normally thi
12 matches
Mail list logo
