Re: [gdal-dev] std::numeric_limits::min() vs LLONG_MIN

2022-12-18 Thread Paul Meems
Thank you Even. Paul Op zo 18 dec. 2022 om 22:59 schreef Even Rouault : > Paul, > > I've queued your proposed fix in pull request > https://github.com/OSGeo/gdal/pull/6943 > > Even > Le 18/12/2022 à 22:18, Paul Meems a écrit : > > I made the brackets bold. That seems to result in the * > Only (

Re: [gdal-dev] std::numeric_limits::min() vs LLONG_MIN

2022-12-18 Thread Even Rouault
Paul, I've queued your proposed fix in pull request https://github.com/OSGeo/gdal/pull/6943 Even Le 18/12/2022 à 22:18, Paul Meems a écrit : I made the brackets bold. That seems to result in the * Only ( and ) are needed, no *. Regards, Paul Op zo 18 dec. 2022 18:39 schreef Andrew C Aitchi

Re: [gdal-dev] std::numeric_limits::min() vs LLONG_MIN

2022-12-18 Thread Paul Meems
I made the brackets bold. That seems to result in the * Only ( and ) are needed, no *. Regards, Paul Op zo 18 dec. 2022 18:39 schreef Andrew C Aitchison : > On Sun, 18 Dec 2022, Paul Meems wrote: > > > Thanks all for your suggestions. > > I did some more research and it seems to be an issue with

Re: [gdal-dev] std::numeric_limits::min() vs LLONG_MIN

2022-12-18 Thread Andrew C Aitchison
On Sun, 18 Dec 2022, Paul Meems wrote: Thanks all for your suggestions. I did some more research and it seems to be an issue with the preprocessor on Windows. Adding some brackets solves the issue as well: // old constexpr int64_t GDAL_PAM_DEFAULT_NODATA_VALUE_INT64 = std::numeric_limits::min()

Re: [gdal-dev] std::numeric_limits::min() vs LLONG_MIN

2022-12-18 Thread Paul Meems
Thanks all for your suggestions. I did some more research and it seems to be an issue with the preprocessor on Windows. Adding some brackets solves the issue as well: // old constexpr int64_t GDAL_PAM_DEFAULT_NODATA_VALUE_INT64 = std::numeric_limits::min(); constexpr uint64_tGDAL_PAM_DEFAULT_NODAT

Re: [gdal-dev] std::numeric_limits::min() vs LLONG_MIN

2022-12-16 Thread dg0yt
I'm not using MSVC, so this is a guess: Are you including 'windows.h' without 'NOMINMAX' being defined? Then you will get macros which interfere with the limits code. Regards, Kai. > Paul Meems hat am 17.12.2022 00:46 CET geschrieben: > > > Thanks, Kurt for your response. > > I'm getting a ve

Re: [gdal-dev] std::numeric_limits::min() vs LLONG_MIN

2022-12-16 Thread Kurt Schwehr
My suggestion is try a small example program with not much more than those two lines and then give the exact / complete compile line and output. Better yet, try to reproduce it with a small example on compiler explorer: https://godbolt.org/ On Fri, Dec 16, 2022 at 3:47 PM Paul Meems wrote: > Th

Re: [gdal-dev] std::numeric_limits::min() vs LLONG_MIN

2022-12-16 Thread Paul Meems
Thanks, Kurt for your response. I'm getting a very vague error message: E0040 expected an identifier. Regards, Paul Op za 17 dec. 2022 om 00:40 schreef Kurt Schwehr : > What exact error are you getting? > > On Fri, Dec 16, 2022 at 3:31 PM Paul Meems wrote: > >> Hello List, >> >> We're trying

Re: [gdal-dev] std::numeric_limits::min() vs LLONG_MIN

2022-12-16 Thread Kurt Schwehr
What exact error are you getting? On Fri, Dec 16, 2022 at 3:31 PM Paul Meems wrote: > Hello List, > > We're trying to update MapWinGIS which is using the GDAL libraries from > gisinternals.com > Currently, we use the stable daily of December 9: > *release-1928-gdal-3-5-mapserver-8-0* > > I'm usi

[gdal-dev] std::numeric_limits::min() vs LLONG_MIN

2022-12-16 Thread Paul Meems
Hello List, We're trying to update MapWinGIS which is using the GDAL libraries from gisinternals.com Currently, we use the stable daily of December 9: *release-1928-gdal-3-5-mapserver-8-0* I'm using VS2019 (on Windows) to compile and I'm having issues with two lines in gdal_pam.h, around line 215