Re: [gdal-dev] WAsP map output for ogr

2014-03-13 Thread Even Rouault
Le jeudi 13 mars 2014 20:19:58, Vincent Mora a écrit : > Ticket & patch http://trac.osgeo.org/gdal/ticket/5416 Commited. There is however an issue when GEOS isn't available. See ticket. > > On 13/03/2014 09:56, Even Rouault wrote: > > Selon Vincent Mora : > >> On 12/03/2014 10:57, Even Rouault w

Re: [gdal-dev] WAsP map output for ogr

2014-03-13 Thread Vincent Mora
Ticket & patch http://trac.osgeo.org/gdal/ticket/5416 On 13/03/2014 09:56, Even Rouault wrote: Selon Vincent Mora : On 12/03/2014 10:57, Even Rouault wrote: Le mercredi 12 mars 2014 08:53:44, Vincent Mora a écrit : I've question concerning SRS: what should OGRWAsPLayer::GetSpatialRef() for u

Re: [gdal-dev] WAsP map output for ogr

2014-03-13 Thread Even Rouault
Selon Vincent Mora : > On 12/03/2014 10:57, Even Rouault wrote: > > Le mercredi 12 mars 2014 08:53:44, Vincent Mora a écrit : > >> I've question concerning SRS: what should OGRWAsPLayer::GetSpatialRef() > >> for unknown SRS. > > NULL would be OK. > The shapefile and postgis drivers don't appear to

Re: [gdal-dev] WAsP map output for ogr

2014-03-13 Thread Vincent Mora
On 12/03/2014 10:57, Even Rouault wrote: Le mercredi 12 mars 2014 08:53:44, Vincent Mora a écrit : I've question concerning SRS: what should OGRWAsPLayer::GetSpatialRef() for unknown SRS. NULL would be OK. The shapefile and postgis drivers don't appear to like NULL values for SRS.

Re: [gdal-dev] WAsP map output for ogr

2014-03-12 Thread Even Rouault
Le mercredi 12 mars 2014 08:53:44, Vincent Mora a écrit : > I've question concerning SRS: what should OGRWAsPLayer::GetSpatialRef() > for unknown SRS. NULL would be OK. > > > > Context: > > WAsP Map Editor has a couple of SRS that will be written in the first > line of the .map file. The firs

Re: [gdal-dev] WAsP map output for ogr

2014-03-12 Thread Vincent Mora
I've question concerning SRS: what should OGRWAsPLayer::GetSpatialRef() for unknown SRS. Context: WAsP Map Editor has a couple of SRS that will be written in the first line of the .map file. The first line looks like +description | srs_name | map_editor version Since there are very fe

Re: [gdal-dev] WAsP map output for ogr

2014-03-12 Thread Vincent Mora
On 11/03/2014 14:58, Even Rouault wrote: Selon Vincent Mora : On 11/03/2014 10:39, Even Rouault wrote: If you want to test the compliance of your driver (the read part) with the assumptions of the OGR API, you can go to the apps subdirectory of GDAL and "make test_ogrsf", and then "test_ogrsf

Re: [gdal-dev] WAsP map output for ogr

2014-03-11 Thread Even Rouault
Selon Vincent Mora : > > On 11/03/2014 10:39, Even Rouault wrote: > > If you want to test the compliance of your driver (the read part) with the > > assumptions of the OGR API, you can go to the apps subdirectory of GDAL and > > "make test_ogrsf", and then "test_ogrsf a_wasp_file". > Thanks for th

Re: [gdal-dev] WAsP map output for ogr

2014-03-11 Thread Vincent Mora
On 11/03/2014 10:39, Even Rouault wrote: If you want to test the compliance of your driver (the read part) with the assumptions of the OGR API, you can go to the apps subdirectory of GDAL and "make test_ogrsf", and then "test_ogrsf a_wasp_file". Thanks for the tip. It helped me fix some issues

Re: [gdal-dev] WAsP map output for ogr

2014-03-11 Thread Even Rouault
Hi Vincent, > The driver is now R/W. ok I now realize that oErrorRegion.Intersect( oEnvelope ) is on the OGREnvelope class and not OGRGeometry (in later case it is a boolean operation, hence my erroneous note). If you want to test the compliance of your driver (the read part) with the assumption

Re: [gdal-dev] WAsP map output for ogr

2014-03-11 Thread Vincent Mora
The driver is now R/W. Thanks for your comments (answer below). On 09/03/2014 19:58, Even Rouault wrote: Hi, my quick review : - ogrwaspdatasource.cpp : * change author and copyright to yours Done. * why do you need #ifdef _WIN32 # include #endif Not needed indeed, removed. * G

Re: [gdal-dev] WAsP map output for ogr

2014-03-09 Thread Even Rouault
Hi, my quick review : - ogrwaspdatasource.cpp : * change author and copyright to yours * why do you need #ifdef _WIN32 # include #endif * GetLayer() : index start at 0, not 1 * WASP_MERGE: you could use CSLTestBoolean(CSLFetchNameValueDef( papszOptions, "WASP_MERGE", "YES" )) - ogrwa

Re: [gdal-dev] WAsP map output for ogr

2014-03-06 Thread Vincent Mora
A write-only driver if I understand well ? There are not so many instances of such drivers. I can think to the PGDump driver. I have a write-only driver here: https://github.com/Oslandia/gdal_wasp It's working but not complete, what I'll add in the next two weeks: - unit tests. - a line

Re: [gdal-dev] WAsP map output for ogr

2014-02-25 Thread Even Rouault
Vincent, > > I'd like to develop a ogr driver to create .map files used by WAsP > > > The .map files contains height contours and roughness zones, the former > are linestrings with an height attribute, the later are linestrings that > separate two adjacent poly

[gdal-dev] WAsP map output for ogr

2014-02-25 Thread Vincent Mora
Hi, I'd like to develop a ogr driver to create .map files used by WAsP The .map files contains height contours and roughness zones, the former are linestrings with an height attribute, the later are linestrings that separate two adjacent polygons with a roughn