Re: [gdal-dev] S57 questions

2010-06-04 Thread ogr user
Frank, I submitted an improved patch (it adds a method to OGRPolygon and will work a lot faster for polygon assembly, no need to copy all those rings). If that's not acceptable - it may be possible to simply collect rings in an array and build a polygon that way. Would you mind taking a look? og

Re: [gdal-dev] S57 questions

2010-06-01 Thread ogr user
Done, http://trac.osgeo.org/gdal/ticket/3610 Frank Warmerdam wrote: > Mike, > > This would indeed be a useful change. I'd encourage you to file it in > Trac > and I'll look at incorporating it. > > Best regards, ___ gdal-dev mailing list gdal-dev@lists.

Re: [gdal-dev] S57 questions

2010-05-31 Thread Frank Warmerdam
ogr user wrote: This patch does not do anything regarding direction of winding. What it does is - discover the exterior ring for a polygon, and make it the first ring in the polygon object. This was in response to your earlier comment that said "The S-57 driver uses OGRBuildPolygonFromEdges() to

Re: [gdal-dev] S57 questions

2010-05-31 Thread ogr user
This patch does not do anything regarding direction of winding. What it does is - discover the exterior ring for a polygon, and make it the first ring in the polygon object. This was in response to your earlier comment that said "The S-57 driver uses OGRBuildPolygonFromEdges() to form the set of l

Re: [gdal-dev] S57 questions

2010-05-31 Thread Frank Warmerdam
ogr user wrote: Dear all and Frank, I sent this patch out a few times before - never got any replies. It's ok if you are not interested, though I have to say that it works very well for me and improved handling of data. However, would someone kindly confirm that you have looked at this patch, a

Re: [gdal-dev] S57 questions

2010-05-31 Thread ogr user
Dear all and Frank, I sent this patch out a few times before - never got any replies. It's ok if you are not interested, though I have to say that it works very well for me and improved handling of data. However, would someone kindly confirm that you have looked at this patch, acknowledged it and

Re: [gdal-dev] S57 questions

2009-12-16 Thread ogr user
In case anyone is interested, here is a simple patch for the polygon outer ring issue. It's not a perfect way to detect the outer ring since in some cases inner rings can have the *same* envelope area as the outer ring, but in any practical chart case this works just fine. Calculating actual ring a

Re: [gdal-dev] S57 questions

2009-12-15 Thread Frank Warmerdam
ogr user wrote: I wonder if anyone here with a good knowledge of S57 format internals can help me out on this issue. OGR S57 parser seems to work quite well with most charts in NOAA ENC data set. However, I found a feature on one of the charts that puzzles me (to be specific, the chart is US5CA9

[gdal-dev] S57 questions

2009-12-15 Thread ogr user
I wonder if anyone here with a good knowledge of S57 format internals can help me out on this issue. OGR S57 parser seems to work quite well with most charts in NOAA ENC data set. However, I found a feature on one of the charts that puzzles me (to be specific, the chart is US5CA92M, the feature RC