On 17 October 2015 at 12:54, Even Rouault wrote:
> Le samedi 17 octobre 2015 00:25:45, Kurt Schwehr a écrit :
>> I personally like foo_, but m_ is fine. I worry about unexpected side
>> effects of changing member naming with private members. I don't think
>> there will be any if everything build
Le samedi 17 octobre 2015 00:25:45, Kurt Schwehr a écrit :
> I personally like foo_, but m_ is fine. I worry about unexpected side
> effects of changing member naming with private members. I don't think
> there will be any if everything builds, but I still worry.
There can be subtle effects inde
On 17 October 2015 at 00:25, Kurt Schwehr wrote:
> I personally like foo_, but m_ is fine.
I personally too, but we should stick to what has already been used in GDAL.
> I worry about unexpected side
> effects of changing member naming with private members.
I don't suggest changing members visi
I personally like foo_, but m_ is fine. I worry about unexpected side
effects of changing member naming with private members. I don't think
there will be any if everything builds, but I still worry. If we go for
changing publics, we should pick a time and go for a major version number
bump and e
On 16 October 2015 at 22:47, Even Rouault wrote:
>
>> I'm not proposing any changes to naming convention. AFAICT, currently GDAL
>> either uses m_ prefix or nothing.
>
> Well, I think you'll agree that using m_foo or bla_ is a naming convention,
Right, I meant, to actually apply unified conventio
> I'm not proposing any changes to naming convention. AFAICT, currently GDAL
> either uses m_ prefix or nothing.
Well, I think you'll agree that using m_foo or bla_ is a naming convention,
and there's nothing specified in
https://trac.osgeo.org/gdal/wiki/rfc8_devguide related to that.
--
Spa
On 16 Oct 2015 19:30, "Even Rouault" wrote:
> Le vendredi 16 octobre 2015 18:11:17, Mateusz Loskot a écrit :
> > Hi,
> >
> > I noticed Kurt has been applying lots of non-functional code
improvements,
> > refactoring, and cleaning compilation warnings, etc.
> >
> > I have been considering similar c
Le vendredi 16 octobre 2015 18:11:17, Mateusz Loskot a écrit :
> Hi,
>
> I noticed Kurt has been applying lots of non-functional code improvements,
> refactoring, and cleaning compilation warnings, etc.
>
> I have been considering similar clean-up also to unify class member names
> which often le
Hi,
I noticed Kurt has been applying lots of non-functional code improvements,
refactoring, and cleaning compilation warnings, etc.
I have been considering similar clean-up also to unify class member names
which often lead to compilation warnings due to declaration hiding.
I committed a short ex
