Re: [gdal-dev] Patch to improve libjpeg compatibility on gdal 1.11

2015-02-18 Thread David Weiß
> Hum, I've tried to replicate a minimalistic version of libjpeg_io.cpp: > > > """ > namespace PCIDSK > { > }; > > #include "cpl_port.h" > > using namespace PCIDSK; > > extern "C" { > typedef enum { FALSE = 0, TRUE = 1 } boolean; } """ > > The above fails to compile because cpl_port.h contain

Re: [gdal-dev] Patch to improve libjpeg compatibility on gdal 1.11

2015-02-18 Thread Even Rouault
Le mercredi 18 février 2015 11:04:32, David Weiß a écrit : > Hey Even, > > > Where I'm confused now is that I don't need any patch in the 1.11 branch > > to compile against 9a... > > > > The releavant extract of the output of g++ -E on libjpeg_io.cpp is {{{ # > > 309 "/home/even/install-jpeg-9a/i

Re: [gdal-dev] Patch to improve libjpeg compatibility on gdal 1.11

2015-02-18 Thread David Weiß
Hey Even, > Where I'm confused now is that I don't need any patch in the 1.11 branch to > compile against 9a... > > The releavant extract of the output of g++ -E on libjpeg_io.cpp is {{{ # 309 > "/home/even/install-jpeg-9a/include/jmorecfg.h" > typedef int boolean; > }}} > > so it doesn't use at

Re: [gdal-dev] Patch to improve libjpeg compatibility on gdal 1.11

2015-02-17 Thread Even Rouault
David, Hum I can see http://trac.osgeo.org/gdal/changeset/27926#file1 was accidentaly committed with an unrelated commit (and should probably be related). When digging a bit, it was related to experiments I did with libjpegv9 (not 9a) which dates back to 2013 whereas 9a is from 2014, and has a

[gdal-dev] Patch to improve libjpeg compatibility on gdal 1.11

2015-02-17 Thread David Weiß
Hey, the attached patch against the 1.11 branch from svn is basically a backport from the 2.0 branch. It fixes a namespace problem in frmts/pcidsk/sdk/core/libjpeg_io.cpp when building gdal against a current libjpeg version (newer than v6b, tested with v9a). The technical reason is that libjpe