Re: [gdal-dev] OGRGeometry copy constructor

2015-06-07 Thread Simon Hege
Even, I submitted the patch as http://trac.osgeo.org/gdal/ticket/5990 Feel free to ask for improvements if needed. Simon > From: even.roua...@spatialys.com > To: gdal-dev@lists.osgeo.org > Subject: Re: [gdal-dev] OGRGeometry copy constructor > Date: Fri, 5 Jun 2015 17:46:20 +0200

Re: [gdal-dev] OGRGeometry copy constructor

2015-06-05 Thread Even Rouault
Simon, > Looking at the code of GDAL 2.0 (but also 1.x), I noticed that the > OGRGeometry class (and the derived classes) do not respects the Rule of 3 > : there is a destructor and no copy constructor or assignment operator. Indeed, the Rule of 3 is not currently really implemented in the C++ AP

[gdal-dev] OGRGeometry copy constructor

2015-06-05 Thread Simon Hege
Hi, Looking at the code of GDAL 2.0 (but also 1.x), I noticed that the OGRGeometry class (and the derived classes) do not respects the Rule of 3 : there is a destructor and no copy constructor or assignment operator. It seems to me that this may lead to memory leaks on OGRSpatialReference (for