Re: [gdal-dev] Notes on gdalbuildvrt.cpp

> That shouldn't happen because of the return at line 453 Damn, I missed that. :) > Hungarian-style convention Yes, I've read RFC8 ; just thinking out loud. 2014-08-21 22:21 GMT+03:00 Even Rouault : > Le jeudi 21 août 2014 21:13:15, Nicu

Re: [gdal-dev] Notes on gdalbuildvrt.cpp

Le jeudi 21 août 2014 21:13:15, Nicu Tofan a écrit : > Hello Even, > > >- VRTBuilder::pasDatasetProperties line 237 > > DatasetProperty* psDatasetProperties > > This is a variable allocated on the stack; on function entry it contains a > pointer somewhere inside pasDatasetProperties; Say pa

Re: [gdal-dev] Notes on gdalbuildvrt.cpp

Hello Even, - VRTBuilder::pasDatasetProperties line 237 DatasetProperty* psDatasetProperties This is a variable allocated on the stack; on function entry it contains a pointer somewhere inside pasDatasetProperties; Say pasDatasetProperties is 0x750 and psDatasetProperties is 0x7500100. N

Re: [gdal-dev] Notes on gdalbuildvrt.cpp

Le jeudi 21 août 2014 19:32:34, Nicu Tofan a écrit : > Assuming that VRTBuilder class inside gdalbuildvrt.cpp has been created to > be reusable, Not particularly, but your remarks are interesting and beneficial to gdalbuildvrt itself. > I have some comments/questions that, depending on your inp

[gdal-dev] Notes on gdalbuildvrt.cpp

Assuming that VRTBuilder class inside gdalbuildvrt.cpp has been created to be reusable, I have some comments/questions that, depending on your input, may end up in pull requests. - *VRTBuilder::VRTBuilder, line 300* Instead of assigning the pointer create a copy to be consistent with the rest