Hi,
I declare this motion passed with +1 from PSC members KurtS and me.
Even
Le 24/11/2022 à 09:39, ElPaso a écrit :
Hi,
Motion:
Adopt RFC88: RFC69 C/C++ Code Formatting [1]
I have updated the RFC [1] to use pre-commit and I have created a
draft implementation of the pre-commit hook and th
Hi Even,
On Mon, 28 Nov 2022 at 16:14, Even Rouault
wrote:
> The Big reformat commit itself
> should be done with a dedicated github account, like we did with the
> "git mv gdal/* ." tree-reorganisation to avoid unfair commit statistics.
Git supports blame-ignore files [1], which will "Ignore
+1. Having the hooks makes this feasible.
Thank you for pickup the work that I let fall on the floor so long ago!
On Mon, Nov 28, 2022 at 9:46 AM Javier Jimenez Shaw
wrote:
> Yes, those are two different issues: attribution and "blame", that is
> really bothering when you want to see the histor
Yes, those are two different issues: attribution and "blame", that is
really bothering when you want to see the history. Your comment reminded me
that other.
(Sorry for the format, I'm having problems with my phone)
On Mon, 28 Nov 2022, 18:35 Even Rouault, wrote:
>
> Le 28/11/2022 à 18:17, Javi
Le 28/11/2022 à 18:17, Javier Jimenez Shaw a écrit :
Which version of clang-format are we using?
15.0.4 currently, pinned in the pre-commit configuration file. cf
https://github.com/OSGeo/gdal/pull/6787#issuecomment-1327416250 . It is
installed automatically when running pre-commit. Works fine
Which version of clang-format are we using? (I saw 3.8 somewhere n the
code?) Older versions are not easy to get in modern operating systems. In
Ubuntu 22.04 the default is clang-format-14. It is specially hard in MacOS,
friends told me.
About the blame problems, we can do this:
https://akrabat.co
Hi,
+1 and I'm very much for the "Big reformat", otherwise as discussed with
Alessandro, I'm afraid occasional contributors will mix substantial and
formatting changes in the same commit. The Big reformat commit itself
should be done with a dedicated github account, like we did with the
"git
Hi,
Motion:
Adopt RFC88: RFC69 C/C++ Code Formatting [1]
I have updated the RFC [1] to use pre-commit and I have created a draft
implementation of the pre-commit hook and the CI integration with a GH
workflow [2].
If adopted, we still have to agree on which coding style to apply (for
now I
