(Just saw Jonathan's email)
That approach to `ids` makes sense to me. Let's try and get the current PR
merged and I'll submit that as a followup PR (I have a few other minor
changes I want to make too, but have been holding off since the current one
is too enormous as-is)
On Tue, 11 Dec 2018 at 1
Thanks for the votes and kind words :)
I'd applied Kurt's super-minor wording suggestions but haven't added any
new sections (on fiona, extra examples, etc) yet. I'll try and incorporate
those changes in the next couple days.
Cheers
Craig
On Tue, 11 Dec 2018 at 11:07 Kurt Schwehr wrote:
> To f
Hi Craig,
For my suite I've used pytest_make_parameterize_id to auto-create id's
using the first parameterised value as the id name if that parameter is
called "_" (just underscore - the Python convention for a throwaway
variable). It works really well, although would need some work for
backw
To follow on to Howard's comment about testing in python...
I'm looking forward to the day that GDAL can drop all python 2.x support
and testing!
And anyone working on C++ testing is welcome to the code here. I'll
happily donate it with a license change to GDAL (it's apache 2.0 right
now). You
On jeudi 6 décembre 2018 11:40:49 CET Craig de Stigter wrote:
> Hi
>
> I appreciate your comments on the pytest proposal and all the support to
> help get it this far. Given no actionable improvements have been suggested,
> and the feedback thus far seems encouraging...
>
> I move to adopt RFC 72
+1 Kurt
Awesome!! It's great to see that my work in
https://github.com/schwehr/gdal-autotest2/tree/master/python is obsolete.
Some very minor suggestions:
- "Support testing under Python 2 & Python 3 (2.7+)" Move the (2.7+) to be
with Python 2.
- Mention that Fiona and Rasterio also use pytest
-
+1
I watched the ticket traffic and shuddered :) Thank you. GDAL's testing
probably predates five or six Python testing regimes/eras. I also have
the concern about GDAL's testing going through Python, but this RFC will
make it much easier for people to contribute and improve the story.
Congratu
I haven't had a chance to read the RFC yet, so I can't yet vote. However,
a huge thank you to Craig and everyone else who put in effort to make this
happen!
On Sun, Dec 9, 2018 at 7:05 PM Craig de Stigter <
craig.destig...@koordinates.com> wrote:
> Jonathan
>
> > it's worth spending a little tho
Jonathan
> it's worth spending a little thought on coming up with a scheme for
test-ids.
I've been through the list of parametrized tests and tweaked the `ids`
kwargs to make them a little more helpful at first glance:
https://github.com/OSGeo/gdal/pull/963/commits/8db599e7bc08b7dc73d81591898ed0f
+0
-Jukka Rahkonen-
Even Rouault-2 wrote
> PSC members,
>
> gentle reminder to cast your vote on this.
>
> Thanks,
>
> Even
--
Sent from: http://osgeo-org.1560.x6.nabble.com/GDAL-Dev-f3742093.html
___
gdal-dev mailing list
gdal-dev@lists.osgeo.
Hi,
PyTest is a great test-suite.
If I may make one suggestion as someone who has used it for a while -
it's worth spending a little thought on coming up with a scheme for
test-ids. Especially if you're going to use parameterisation.
Otherwise PyTest comes up with names that may be accurate
+1
Daniel
On 2018-12-07 6:15 a.m., Even Rouault wrote:
PSC members,
gentle reminder to cast your vote on this.
Thanks,
Even
Hi
I appreciate your comments on the pytest proposal and all the support to
help get it this far. Given no actionable improvements have been suggested,
and the feed
PSC members,
gentle reminder to cast your vote on this.
Thanks,
Even
> Hi
>
> I appreciate your comments on the pytest proposal and all the support to
> help get it this far. Given no actionable improvements have been suggested,
> and the feedback thus far seems encouraging...
>
> I move to a
On jeudi 6 décembre 2018 11:40:49 CET Craig de Stigter wrote:
> Hi
>
> I appreciate your comments on the pytest proposal and all the support to
> help get it this far. Given no actionable improvements have been suggested,
> and the feedback thus far seems encouraging...
>
> I move to adopt RFC 72
Hi
I appreciate your comments on the pytest proposal and all the support to
help get it this far. Given no actionable improvements have been suggested,
and the feedback thus far seems encouraging...
I move to adopt RFC 72: Run tests with pytest.
https://trac.osgeo.org/gdal/wiki/rfc72_pytest
Ch
15 matches
Mail list logo
