Re: [gdal-dev] C4251 warnings in VS2017

2019-06-11 Thread Mateusz Loskot
On 19-06-11 16:48:48, Even Rouault wrote: On mardi 11 juin 2019 16:37:46 CEST Mateusz Loskot wrote: On Tue, 11 Jun 2019 at 16:20, Michel Dastous wrote: > Im asking because ticket #4099 was closed saying it should no longer be an > issue with MSVC2015, so I was expecting it to be fixed in VS20

Re: [gdal-dev] C4251 warnings in VS2017

2019-06-11 Thread Even Rouault
On mardi 11 juin 2019 16:37:46 CEST Mateusz Loskot wrote: > On Tue, 11 Jun 2019 at 16:20, Michel Dastous wrote: > > Im asking because ticket #4099 was closed saying it should no longer be an > > issue with MSVC2015, so I was expecting it to be fixed in VS2017. > Right, I missed that one. I think

Re: [gdal-dev] C4251 warnings in VS2017

2019-06-11 Thread Mateusz Loskot
On Tue, 11 Jun 2019 at 16:20, Michel Dastous wrote: > > Im asking because ticket #4099 was closed saying it should no longer be an > issue with MSVC2015, so I was expecting it to be fixed in VS2017. Right, I missed that one. Chances are some recent tweaks, even the empty initializer list, trigg

Re: [gdal-dev] C4251 warnings in VS2017

2019-06-11 Thread Michel Dastous
- From: gdal-dev On Behalf Of Mateusz Loskot Sent: Tuesday, June 11, 2019 10:14 AM To: gdal-dev@lists.osgeo.org Subject: Re: [gdal-dev] C4251 warnings in VS2017 On Tue, 11 Jun 2019 at 14:46, Michel Dastous wrote: > > Sample warning message: > 1>e:\mapserverlibs\include\ogr_features

Re: [gdal-dev] C4251 warnings in VS2017

2019-06-11 Thread Mateusz Loskot
On Tue, 11 Jun 2019 at 14:46, Michel Dastous wrote: > > Sample warning message: > 1>e:\mapserverlibs\include\ogr_featurestyle.h(89,41): warning C4251: > 'OGRStyleTable::osLastRequestedStyleName': class 'CPLString' needs to have > dll-interface to be used by clients of class 'OGRStyleTable' > 1>

[gdal-dev] C4251 warnings in VS2017

2019-06-11 Thread Michel Dastous
Hi all, I know this is an old issue (according to this ticket https://trac.osgeo.org/gdal/ticket/4099), but surprisingly Im still getting C4251 warnings on VS2017 and GDAL 3 if my project is compiled with /W2 or more. It occurs as soon as I include ogrsf_frmts.h Sample warning message: 1>e:\