Re: [gdal-dev] Un-vendoring a number of third-party libraries?

2023-12-15 Thread Kurt Schwehr via gdal-dev
+1 for un-vendoring. Long term, I think that will be a big win. Looks like others have covered all of the issues that I can think of. On Fri, Dec 15, 2023 at 4:45 PM Greg Troxel via gdal-dev < gdal-dev@lists.osgeo.org> wrote: > Even Rouault via gdal-dev writes: > > > I'm considering removing f

Re: [gdal-dev] Un-vendoring a number of third-party libraries?

2023-12-15 Thread Greg Troxel via gdal-dev
Even Rouault via gdal-dev writes: > I'm considering removing from the source tree a number of third-party > libraries that we have vendored over the years: zlib, libpng, libjpeg, > giflib, liblerc I'm basically strongly in favor of un-vendoring. I view vendoring as a bug, even if it is a workar

Re: [gdal-dev] Un-vendoring a number of third-party libraries?

2023-12-15 Thread Even Rouault via gdal-dev
Andrew, I don't see a problem but libpng also uses zlib. Do we need to do anything to ensure that gdal uses the same zlib as libpng ? It is not the role to GDAL to check this (there's no portable way of doing that AFAIK), but it is obviously the responsibility of the user to make sure that al

Re: [gdal-dev] Un-vendoring a number of third-party libraries?

2023-12-15 Thread Andrew C Aitchison via gdal-dev
On Fri, 15 Dec 2023, Even Rouault via gdal-dev wrote: If the scope of this were to unvendor just these four (libjpeg, libpng, zlib, giflib), I think it is enough to start, but it brings up the question of whether or not JPEG, PNG, and GIF support are hard dependencies in GDAL afterward. They'r

Re: [gdal-dev] Un-vendoring a number of third-party libraries?

2023-12-15 Thread Even Rouault via gdal-dev
If the scope of this were to unvendor just these four (libjpeg, libpng, zlib, giflib), I think it is enough to start, but it brings up the question of whether or not JPEG, PNG, and GIF support are hard dependencies in GDAL afterward. They're always available no matter how you build now, so wou

Re: [gdal-dev] Un-vendoring a number of third-party libraries?

2023-12-15 Thread Howard Butler via gdal-dev
> On Dec 15, 2023, at 8:35 AM, Even Rouault via gdal-dev > wrote: > > Thoughts ? (given the length of the email, it should probably be formalized > as a RFC. I'll do that, unless there is a massive uprising against the > proposal...) If the scope of this were to unvendor just these four (l

Re: [gdal-dev] Un-vendoring a number of third-party libraries?

2023-12-15 Thread Even Rouault via gdal-dev
Le 15/12/2023 à 15:49, Sebastiaan Couwenberg via gdal-dev a écrit : On 12/15/23 15:35, Even Rouault via gdal-dev wrote: Thoughts ? (given the length of the email, it should probably be formalized as a RFC. I'll do that, unless there is a massive uprising against the proposal...) LERC doesn't

Re: [gdal-dev] Un-vendoring a number of third-party libraries?

2023-12-15 Thread Sebastiaan Couwenberg via gdal-dev
On 12/15/23 15:35, Even Rouault via gdal-dev wrote: Thoughts ? (given the length of the email, it should probably be formalized as a RFC. I'll do that, unless there is a massive uprising against the proposal...) LERC doesn't support big endian architectures currently, only using that on littl

[gdal-dev] Un-vendoring a number of third-party libraries?

2023-12-15 Thread Even Rouault via gdal-dev
Hi, I'm considering removing from the source tree a number of third-party libraries that we have vendored over the years: zlib, libpng, libjpeg, giflib, liblerc All of them are widely available in most packaging environments. In that list, only zlib is required (currently either as external

Re: [gdal-dev] Why Open() inside QuietDelete()?

2023-12-15 Thread Abel Pau via gdal-dev
Thanks!! De: Even Rouault Enviado el: dijous, 14 de desembre de 2023 18:00 Para: Abel Pau ; gdal-dev@lists.osgeo.org Asunto: Re: [gdal-dev] Why Open() inside QuietDelete()? Le 14/12/2023 à 17:36, Abel Pau via gdal-dev a écrit : Hi, today I have a very inside-code question... I’m wondering why