Re: [gdal-dev] GDAL/OGR 3.4.1 not reading S57 correctly

2022-01-26 Thread dthorne
Here is the C++ code we have written to read the test s57 file. [ https://pastebin.com/seXrkgmB ]( https://pastebin.com/seXrkgmB ) We feel that it is some setup stuff we have missed but can't find any clear information. For example we hadn't seen GDAL_DATA environment variables mentioned in a

Re: [gdal-dev] Motion: grant github commit rights to Nyall Dawson

2022-01-26 Thread Tamas Szekeres
+1 Tamas Even Rouault ezt írta (időpont: 2022. jan. 26., Sze, 0:34): > Hi, > > I'd like to motion to grant github commit rights to Nyall. We don't have > much people currently doing reviews of pull requests and pressing the > "Merge" button, and Nyall is definitely in a capacity of fulfilling t

Re: [gdal-dev] Motion: grant github commit rights to Nyall Dawson

2022-01-26 Thread Howard Butler
+1 Howard > On Jan 26, 2022, at 3:31 AM, Mateusz Loskot wrote: > > +1 Mateusz > > On Wed, 26 Jan 2022 at 00:34, Even Rouault wrote: >> >> Hi, >> >> I'd like to motion to grant github commit rights to Nyall. We don't have >> much people currently doing reviews of pull requests and pressing t

Re: [gdal-dev] cmake status update - 99% good news!

2022-01-26 Thread Even Rouault
Le 26/01/2022 à 20:56, Joaquim Manuel Freire Luís a écrit : >Ah my if(MSVC) suggestion was because I wrongly assumed you used mingw (the _w64.dll >suffix made me thing of mingw64), but I see the VC14 so you use MSVC. The “_w64.dll” (and _w32.dll) suffixes are the reason why I

Re: [gdal-dev] cmake status update - 99% good news!

2022-01-26 Thread Joaquim Manuel Freire Luís
>Ah my if(MSVC) suggestion was because I wrongly assumed you used mingw (the >_w64.dll >suffix made me thing of mingw64), but I see the VC14 so you use MSVC. The “_w64.dll” (and _w32.dll) suffixes are the reason why I rebuild everything. Is there any way to set them in current cmake solution? It

Re: [gdal-dev] cmake status update - 99% good news!

2022-01-26 Thread Even Rouault
Le 26/01/2022 à 20:41, Joaquim Manuel Freire Luís a écrit : Yes, I’m using MSVC (2022) and yeap, with that change it works fine. great. Queued in https://github.com/OSGeo/gdal/pull/5179 *From:*Even Rouault *Sent:* Wednesday, January 26, 2022 7:34 PM *To:* Joaquim Manuel Freire Luís ; gdal-

Re: [gdal-dev] cmake status update - 99% good news!

2022-01-26 Thread Joaquim Manuel Freire Luís
Yes, I’m using MSVC (2022) and yeap, with that change it works fine. From: Even Rouault Sent: Wednesday, January 26, 2022 7:34 PM To: Joaquim Manuel Freire Luís ; gdal-dev@lists.osgeo.org Subject: Re: [gdal-dev] cmake status update - 99% good news! Le 26/01/2022 à 20:26, Joaquim Manuel Freire

Re: [gdal-dev] cmake status update - 99% good news!

2022-01-26 Thread dg0yt
> ninja: error: 'ws2_32.lib', needed by 'gdal_w64.dll', missing and no known > rule to make it 'ws2_32.lib' is neither the name of a CMake target nor a flag ('-l'). So it is taken as a file by Ninja. However, Ninja is not the linker and so it doesn't find that file. Solutions: - '-lws2_32' (a

Re: [gdal-dev] cmake status update - 99% good news!

2022-01-26 Thread Even Rouault
Le 26/01/2022 à 20:26, Joaquim Manuel Freire Luís a écrit : Ok, sorry you meant the FindHDF4.cmake that comes with GDAL. Doing what you suggested (tried both) makes no difference but commenting     if(WIN32)     #list(APPEND HDF4_LIBRARIES ws2_32.lib)     endif() makes the ws2_32 trou

Re: [gdal-dev] cmake status update - 99% good news!

2022-01-26 Thread Joaquim Manuel Freire Luís
Ok, sorry you meant the FindHDF4.cmake that comes with GDAL. Doing what you suggested (tried both) makes no difference but commenting if(WIN32) #list(APPEND HDF4_LIBRARIES ws2_32.lib) endif() makes the ws2_32 trouble go. Le 26/01/2022 à 20:08, Joaquim Manuel Freire Luís a écr

Re: [gdal-dev] cmake status update - 99% good news!

2022-01-26 Thread Even Rouault
Le 26/01/2022 à 20:08, Joaquim Manuel Freire Luís a écrit : Updated master (sorry, didn’t stop to think if the commit had been merged) However, I have cmake 3.22.1 but it doesn’t have a FindHDF4.cmake, only a FinfHDF5 FindHDF4.cmake is in the GDAL repository, in cmake/modules/packages/Find

Re: [gdal-dev] cmake status update - 99% good news!

2022-01-26 Thread Joaquim Manuel Freire Luís
Updated master (sorry, didn’t stop to think if the commit had been merged) However, I have cmake 3.22.1 but it doesn’t have a FindHDF4.cmake, only a FinfHDF5 I was building with set(HDF4_INCLUDE_DIR C:/programs/compa_libs/hdf-4.2.9/compileds/VC14_34/include) set(H

Re: [gdal-dev] cmake status update - 99% good news!

2022-01-26 Thread Even Rouault
did you update to master or did you try my pull request (not merged yet) ? If only master, can you try to change the reference to "ws2_32.lib" to "ws2_32" in cmake/modules/packages/FindHDF4.cmake as I suggested ? Or perhaps change the if (WIN32) at line 91 to if (MSVC) Le 26/01/2022 à 19:43,

Re: [gdal-dev] cmake status update - 99% good news!

2022-01-26 Thread Joaquim Manuel Freire Luís
Don’t know which commit did it. Updated this afternoon and started to erroring right away with missing 'ws2_32.lib` From: Even Rouault Sent: Wednesday, January 26, 2022 6:36 PM To: Joaquim Manuel Freire Luís ; gdal-dev@lists.osgeo.org Subject: Re: [gdal-dev] cmake status update - 99% good news!

Re: [gdal-dev] cmake status update - 99% good news!

2022-01-26 Thread Even Rouault
Le 26/01/2022 à 19:31, Joaquim Manuel Freire Luís a écrit : I do have HDF4 but before I was able to build till the end. I've here a gdal_w64.dll smiling to me. That's why I said it got worst. Sorry you lost me. Is https://github.com/OSGeo/gdal/pull/5179

Re: [gdal-dev] cmake status update - 99% good news!

2022-01-26 Thread Even Rouault
Le 26/01/2022 à 17:26, Joaquim Manuel Freire Luís a écrit : Joaquim, But I found two other new issues when adding more dependencies 1. C:\programs\compa_libs\gdal_GIT\frmts\mbtiles\mbtilesdataset.cpp(45): fatal error C1083: Cannot open include file: 'zlib.h': No such file or directory To wo

Re: [gdal-dev] cmake status update - 99% good news!

2022-01-26 Thread Even Rouault
Joaquim, But I found two other new issues when adding more dependencies 1. C:\programs\compa_libs\gdal_GIT\frmts\mbtiles\mbtilesdataset.cpp(45): fatal error C1083: Cannot open include file: 'zlib.h': No such file or directory To work around this, I temporarily added zlib.h and zconf.h to frmts

Re: [gdal-dev] cmake status update - 99% good news!

2022-01-26 Thread Joaquim Manuel Freire Luís
Some more news on this before I lose track of it. Couldn't find a way to build against my HDF5 1.10.5 (everything I tried failed) so built HDF51.12.1 and now simple setting set(HDF5_ROOT "C:/programs/compa_libs/hdf5-1.12.1/compileds/VC14_64") finds it and no more troubles (yet found) But I f

[gdal-dev] Add elevation data to gpx files

2022-01-26 Thread APM
Dear List, I like to add elevation data to some gpx files by using ogr directly. The actual files are containing for example:   town        etc Before I asked I created a point layer with DEM data in Qgis 3.22.3. by using the "Point sampling tool" and imported the gpx. I us

Re: [gdal-dev] GDAL/OGR 3.4.1 not reading S57 correctly

2022-01-26 Thread Momtchil Momtchev
Can you post your C++ code? Generally, you have more chances of getting an answer for this type of question on https://gis.stackexchange.com/ On 24/01/2022 06:36, dtho...@pivotmaritime.com wrote: Hi, So I am trying to get a test C++ project built to read S57 files using the gdal/ogr C++ li

Re: [gdal-dev] Motion: grant github commit rights to Nyall Dawson

2022-01-26 Thread Mateusz Loskot
+1 Mateusz On Wed, 26 Jan 2022 at 00:34, Even Rouault wrote: > > Hi, > > I'd like to motion to grant github commit rights to Nyall. We don't have > much people currently doing reviews of pull requests and pressing the > "Merge" button, and Nyall is definitely in a capacity of fulfilling this > r