Re: [gdal-dev] Creating Cloud Optimized GeoTIFFs

2017-12-10 Thread Kurt Schwehr
Thanks Even for the feedback. There have be a few offline discussions going on and Even added some notes to the document on Trac: https://trac.osgeo.org/gdal/wiki/CloudOptimizedGeoTIFF?action=diff&version=11

Re: [gdal-dev] Mass-conversion from NULL to nullptr ready to land

2017-12-10 Thread Kurt Schwehr
+1 for landing it On Dec 10, 2017 6:24 AM, "Mateusz Loskot" wrote: > On 10 Dec 2017 14:52, "Even Rouault" wrote: > > > > > (*) sed "s/NULL/nullptr/g" is not an option, as there is a significant > number of occurences of NULL being in a string (think to SQL statements). > > clang-tidy works grea

Re: [gdal-dev] Mass-conversion from NULL to nullptr ready to land

2017-12-10 Thread Mateusz Loskot
On 10 Dec 2017 14:52, "Even Rouault" wrote: (*) sed "s/NULL/nullptr/g" is not an option, as there is a significant number of occurences of NULL being in a string (think to SQL statements). clang-tidy works great, but as it does a true parsing of the code, you need to pass it the same -D and -

[gdal-dev] Mass-conversion from NULL to nullptr ready to land

2017-12-10 Thread Even Rouault
Hi, With the assistance of clang-tidy (*) and a bit of manual editing, I've replaced most uses of NULL with nullptr in .cpp files, and got to the point where all our CI targets are happy with - Wzero-as-null-pointer-constant, which warns about most uses of NULL or 0 or FALSE instead of nullpt