Re: [gdal-dev] MrSID Color Spaces

2017-05-17 Thread Martin Chapman
Even, That's correct, I did not actually build it. Our third party libraries are built by another person on the team and it doesn't happen quick. I thought he was asking me whether it looks correct. I apologize for the mis-communication. Best regards, Martin From: Even Rouault [mail

Re: [gdal-dev] MrSID Color Spaces

2017-05-17 Thread Even Rouault
On mercredi 17 mai 2017 09:10:42 CEST Martin Chapman wrote: > It’s an enum value defined in at least version 8.0 and greater. Maybe in > earlier versions but I am using version 9.1. > Indeed, that's an *enum value*, not a #define ! typedef enum LTIColorSpace { [...] LTI_COLORSPACE_GRAYSCALEA

Re: [gdal-dev] MrSID Color Spaces

2017-05-17 Thread Martin Chapman
It’s an enum value defined in at least version 8.0 and greater. Maybe in earlier versions but I am using version 9.1. Martin From: Even Rouault [mailto:even.roua...@spatialys.com] Sent: Wednesday, May 17, 2017 8:39 AM To: Martin Chapman Cc: 'SIMON Nicolas'; gdal-dev@lists.osgeo.org Subjec

Re: [gdal-dev] What warnings in r38007 require casting int const to double?

2017-05-17 Thread Even Rouault
On mercredi 17 mai 2017 07:50:23 CEST Kurt Schwehr wrote: > Ok. I will try reverting just those casts today and if it break travis, I > will put them back with a comment as to why I don't think this will break Travis since that comes from changesets you introduced days/ weeks before, so we would

Re: [gdal-dev] What warnings in r38007 require casting int const to double?

2017-05-17 Thread Kurt Schwehr
Ok. I will try reverting just those casts today and if it break travis, I will put them back with a comment as to why On May 17, 2017 7:34 AM, "Even Rouault" wrote: > On mercredi 17 mai 2017 07:13:39 CEST Kurt Schwehr wrote: > > > +gdal-dev > > > > > > On Wed, May 17, 2017 at 7:12 AM, Kurt Schwe

Re: [gdal-dev] MrSID Color Spaces

2017-05-17 Thread Even Rouault
On mercredi 17 mai 2017 08:26:00 CEST Martin Chapman wrote: > Nicolas, > > > > Looks good bud! Thanks! I've just applied it to trunk, but couldn't really test it since it seems my MrSID version doesn't have those #define Even > > > > Best regards, > > Martin > > > > From: SIMON Nico

Re: [gdal-dev] What warnings in r38007 require casting int const to double?

2017-05-17 Thread Even Rouault
On mercredi 17 mai 2017 07:13:39 CEST Kurt Schwehr wrote: > +gdal-dev > > On Wed, May 17, 2017 at 7:12 AM, Kurt Schwehr wrote: > > Hi Even, > > > > Do you remember what warning by which compiler with this changeset? Hum of course not :-) It might be some older compiler/distribution I tested be

Re: [gdal-dev] MrSID Color Spaces

2017-05-17 Thread Martin Chapman
Nicolas, Looks good bud! Thanks! Best regards, Martin From: SIMON Nicolas [mailto:nicolas.si...@spw.wallonie.be] Sent: Wednesday, May 17, 2017 4:41 AM To: Martin Chapman Cc: gdal-dev@lists.osgeo.org; Even Rouault Subject: RE: [gdal-dev] MrSID Color Spaces Martin, Could you test

Re: [gdal-dev] What warnings in r38007 require casting int const to double?

2017-05-17 Thread Kurt Schwehr
+gdal-dev On Wed, May 17, 2017 at 7:12 AM, Kurt Schwehr wrote: > Hi Even, > > Do you remember what warning by which compiler with this changeset? > > Thanks, > -kurt > > https://trac.osgeo.org/gdal/changeset/38007 > "Message: Fix warnings about alteration of constant value" > > if( dfD

Re: [gdal-dev] MrSID Color Spaces

2017-05-17 Thread SIMON Nicolas
Martin, Could you test this patch ? Nicolas De : gdal-dev [mailto:gdal-dev-boun...@lists.osgeo.org] De la part de Even Rouault Envoyé : mardi 16 mai 2017 18:28 À : Martin Chapman Cc : gdal-dev@lists.osgeo.org Objet : Re: [gdal-dev] MrSID Color Spaces On mardi 16 mai 2017 10:13:52 CEST Martin Ch