Kurt,
> 1) C char * string vrs std::string vrs CPLString
> I'm not a fan of CPLString, so I'm glad you didn't use that. But all over
> the code I see the use of CPLString when a std::string would work just
> fine. And if I remember correctly, I've seen you do this before. Why
> didn't you use
Even,
w.r.t. https://trac.osgeo.org/gdal/changeset/38344
It might be a good time to ask you a couple of style questions. It would
be good to have an explanation of why you chose to implement it the way you
did. I aim for code that is of the same style for chunks that are both
small and large...
I only fixed one so far, bug-security though.
Even is on rage! Incredible :D
Mateusz
On 14 May 2017 00:42, "Kurt Schwehr" wrote:
> Even and Mateusz,
>
> OMG! So many fixes... Awesome!
>
> -kurt
>
>
>
> On Wed, May 10, 2017 at 5:55 AM, Even Rouault
> wrote:
>
>> On lundi 8 mai 2017 14:46:45 C