Re: [gdal-dev] CAD (DWG) Driver

2016-09-27 Thread Kurt Schwehr
Ran out of time, but I got part way through and a lot of the comments are repeats. https://github.com/OSGeo/gdal/pull/145#pullrequestreview-1773851 On Tue, Sep 27, 2016 at 9:44 AM, Kurt Schwehr wrote: > I'm giving a quick look over. > > On Tue, Sep 27, 2016 at 7:47 AM, Dmitry Baryshnikov > wro

Re: [gdal-dev] Multithread deadlock

2016-09-27 Thread Even Rouault
Le mardi 27 septembre 2016 16:35:26, Francisco Javier Calzado a écrit : > Hi Even, > > Your changes have fixed the issue with multiple threads, now they can write > simultaneously without getting locked. I've done some test in GTiff format > and everything went OK. Did you try with other drivers

Re: [gdal-dev] CAD (DWG) Driver

2016-09-27 Thread Kurt Schwehr
I'm giving a quick look over. On Tue, Sep 27, 2016 at 7:47 AM, Dmitry Baryshnikov wrote: > Hi, > > It seems to me the CAD (DWG) driver developed during Google Summer of Code > 2016 is ready to merge into the trunk. > > The pool request (https://github.com/OSGeo/gdal/pull/145) passed all > checks

[gdal-dev] CAD (DWG) Driver

2016-09-27 Thread Dmitry Baryshnikov
Hi, It seems to me the CAD (DWG) driver developed during Google Summer of Code 2016 is ready to merge into the trunk. The pool request (https://github.com/OSGeo/gdal/pull/145) passed all checks. Are there any objections? -- Best regards, Dmitry _

Re: [gdal-dev] Multithread deadlock

2016-09-27 Thread Francisco Javier Calzado
Hi Even, Your changes have fixed the issue with multiple threads, now they can write simultaneously without getting locked. I've done some test in GTiff format and everything went OK. However, using a custom-made driver for a new format (called Wizard), a new problem has arisen :( . In that ca

Re: [gdal-dev] Incorrect image bytes from VSIGetMemFileBuffer in GDAL < 2.1.0

2016-09-27 Thread Sean Gillies
On Tue, Sep 27, 2016 at 2:59 PM, Even Rouault wrote: > Le mardi 27 septembre 2016 14:09:30, Sean Gillies a écrit : > > Hi all, > > > > I've got code in Rasterio that calls VSIGetMemFileBuffer to get PNG or > JPEG > > image bytes. With GDAL 1.11, I found that I had to fix the resulting byte > > ar

Re: [gdal-dev] Incorrect image bytes from VSIGetMemFileBuffer in GDAL < 2.1.0

2016-09-27 Thread Even Rouault
Le mardi 27 septembre 2016 14:09:30, Sean Gillies a écrit : > Hi all, > > I've got code in Rasterio that calls VSIGetMemFileBuffer to get PNG or JPEG > image bytes. With GDAL 1.11, I found that I had to fix the resulting byte > array by moving the last byte to the head of the array. With GDAL 2.1.

[gdal-dev] Incorrect image bytes from VSIGetMemFileBuffer in GDAL < 2.1.0

2016-09-27 Thread Sean Gillies
Hi all, I've got code in Rasterio that calls VSIGetMemFileBuffer to get PNG or JPEG image bytes. With GDAL 1.11, I found that I had to fix the resulting byte array by moving the last byte to the head of the array. With GDAL 2.1.0 and 2.1.1 this is no longer needed and we can return an unshifted ar

Re: [gdal-dev] Multithread deadlock

2016-09-27 Thread Francisco Javier Calzado
Hi Even, Thanks for such a quick fix! I'm gonna apply the patch and recompile GDAL and will let you know :) Keep in touch. Best Regards, Javier Calzado -Original Message- From: Even Rouault [mailto:even.roua...@spatialys.com] Sent: 26 September, 2016 17:53 To: gdal-dev@lists.osgeo.or