Re: Rust front-end

On Mon, Jun 27, 2022 at 4:52 PM Philip Herron wrote: > > Hi everyone, > > Since November 2020, I've worked full-time on the Rust front-end for > GCC, thanks to Open Source Security, Inc and Embecosm. As a result, I > am writing to this mailing list to seek feedback from the collective > experience

Re: Rust front-end

On Fri, Jul 8, 2022 at 7:32 PM Philip Herron wrote: > > Hi Richard > > Thanks for your detailed response, I took some time to figure this out > myself to give a decent response. It seems like we should keep the end > of the year as our goal to aim for but in the meantime see if we can > split patc

Re: [PATCH Rust front-end v2 09/37] gccrs: Add Lexer for Rust front-end

On Wed, Aug 24, 2022 at 2:04 PM wrote: > > From: The Other > > The lexer is refered to as a ManagedTokenSource within the parser, this > lexer does not currently support unicode but serves as a starting point > to do so. > > Co-authored-by: Philip Herron > Co-authored-by: Arthur Cohen > Co-auth

Re: [PATCH Rust front-end v2 31/37] gccrs: Add GCC Rust front-end Make-lang.in

On Wed, Aug 24, 2022 at 2:22 PM wrote: > > From: Philip Herron > > This is the Makefile for our front-end. > --- > gcc/rust/Make-lang.in | 400 ++ > 1 file changed, 400 insertions(+) > create mode 100644 gcc/rust/Make-lang.in > > diff --git a/gcc/rust/Mak

Re: [PATCH Rust front-end v2 34/37] gccrs: add lang.opt

On Wed, Aug 24, 2022 at 2:13 PM wrote: > > From: Philip Herron > > We have some rust specific langugage options note -fwrapv is enabled by > default in the code. We are trying to respect options such as > -Wunused-result which we get by porting over c++ no-discard for rust's > must-use attribute,

Re: [PATCH Rust front-end v2 32/37] gccrs: Add config-lang.in

On Wed, Aug 24, 2022 at 2:19 PM wrote: > > From: Philip Herron > > This was a copy paste from gccgo front-end, we do not use any of the > target_libs yet but we will need these when we support the libpanic crate. LGTM > --- > gcc/rust/config-lang.in | 34 ++ > 1

Re: [PATCH Rust front-end v2 33/37] gccrs: add lang-spec.h

On Wed, Aug 24, 2022 at 2:20 PM wrote: > > From: Philip Herron > > This specifies the extensions of the Rust language. LGTM > --- > gcc/rust/lang-specs.h | 26 ++ > 1 file changed, 26 insertions(+) > create mode 100644 gcc/rust/lang-specs.h > > diff --git a/gcc/rust/la

Re: [PATCH Rust front-end v2 07/37] gccrs: Add gcc-check-target check-rust

On Wed, Aug 24, 2022 at 2:08 PM wrote: > > From: Philip Herron > > This allows us to invoke the rust testsuite. OK. > > ChangeLog: > * Makefile.def: Add autogen target > * Makefile.in: regenerate via autogen > --- > Makefile.def | 1 + > Makefile.in | 8 > 2 files cha

Re: [PATCH Rust front-end v2 34/37] gccrs: add lang.opt

On Wed, Sep 14, 2022 at 6:20 PM Thomas Schwinge wrote: > > Hi! > > On 2022-09-14T15:39:47+0200, Richard Biener via Gcc-patches > wrote: > > On Wed, Aug 24, 2022 at 2:13 PM wrote: > >> > >> From: Philip Herron > >> > >> We have some rust specific langugage options note -fwrapv is enabled by > >

Re: Rust frontend patches v3

On Fri, Oct 28, 2022 at 1:45 PM Arthur Cohen wrote: > > Hi David, > > On 10/26/22 23:15, David Malcolm wrote: > > On Wed, 2022-10-26 at 10:17 +0200, arthur.co...@embecosm.com wrote: > >> This is the fixed version of our previous patch set for gccrs - We've > >> adressed > >> the comments raised in

Re: [PATCH Rust front-end v3 38/46] gccrs: Add HIR to GCC GENERIC lowering entry point

On Wed, Oct 26, 2022 at 10:37 AM wrote: > > From: Philip Herron > > This patch contains the entry point and utilities used for the lowering > of HIR nodes to `tree`s. It also contains a constant evaluator, ported > over from the C++ frontend. > > Co-authored-by: David Faust > Co-authored-by: Fai

Re: Rust frontend patches v3

On Wed, Oct 26, 2022 at 10:16 AM wrote: > > This is the fixed version of our previous patch set for gccrs - We've adressed > the comments raised in our previous emails. > > This patch set does not contain any work that was not previously included, > such > as closure support, the constant evaluat

Re: [PATCH Rust front-end v3 38/46] gccrs: Add HIR to GCC GENERIC lowering entry point

On Tue, Nov 15, 2022 at 2:46 PM Arthur Cohen wrote: > > > > On 11/9/22 14:53, Richard Biener wrote: > > On Wed, Oct 26, 2022 at 10:37 AM wrote: > >> > >> From: Philip Herron > >> > >> This patch contains the entry point and utilities used for the lowering > >> of HIR nodes to `tree`s. It also co

Re: [PATCH Rust front-end v3 38/46] gccrs: Add HIR to GCC GENERIC lowering entry point

On Tue, Nov 29, 2022 at 7:10 PM Arthur Cohen wrote: > > Hi Richard, > > (...) > > + > + unsigned HOST_WIDE_INT ltype_length > += wi::ext (wi::to_offset (TYPE_MAX_VALUE (ltype_domain)) > +- wi::to_offset (TYPE_MIN_VALUE (ltype_domain)) + 1, > >>> > >>> TYPE_

Re: Rust front-end patches v4

On Tue, Dec 6, 2022 at 11:11 AM wrote: > > This patchset contains the fixed version of our most recent patchset. We > have fixed most of the issues noted in the previous round of reviews, and are > keeping some for later as they would otherwise create too many conflicts with > our updated developm

Re: Make '-frust-incomplete-and-experimental-compiler-do-not-use' a 'Common' option (was: Rust front-end patches v4)

On Wed, Dec 14, 2022 at 11:58 PM Thomas Schwinge wrote: > > Hi! > > On 2022-12-13T14:40:36+0100, Arthur Cohen wrote: > > We've also added one more commit, which only affects files inside the > > Rust front-end folder. This commit adds an experimental flag, which > > blocks the compilation of Rust

Re: [PATCH] testsuite: Add support for Rust and Modula-2 effective target tests

On Thu, 15 Dec 2022, Jakub Jelinek wrote: > Hi! > > This patch allows magic comments also for Rust and Modula-2 > for effective target tests etc. and fixes up the Assembly entry > - it is a glob, so /* Assembly can match /whatever Assembly and > not just /* Assembly. > > Tested on x86_64-linux w

Re: Rust: In 'type_for_mode' langhook also consider all 'int_n' modes/types (was: Modula-2 / Rust: Many targets failing)

On Wed, 22 Feb 2023, Thomas Schwinge wrote: > Hi! > > Richard, you may remember your words from > "ICE: SIGSEGV in optab_for_tree_code (optabs.c:407) with -O > -fno-tree-scev-cprop -ftree-vectorize": > > > Ideally we'd never use lang_hooks.types.type_for_mode (or _

Re: Rust front-end update 2023-04-05

On Wed, Apr 5, 2023 at 4:06 PM wrote: > > Hi everyone, > > This patchset contains around 80 commits concerning the Rust frontend. > > We have been hard at work trying to get the Rust core library to > compile, and hope to push more commits in the coming days as we try > and upstream a more recent

Re: [PATCHSET] Reintroduce targetrustm hooks

On Wed, Sep 13, 2023 at 10:14 PM Iain Buclaw via Gcc-patches wrote: > > Excerpts from Arthur Cohen's message of September 7, 2023 3:41 pm: > > Alright, was not expecting to mess up this patchset so bad so here we go: > > > > This patchset reintroduces proper targetrustm hooks without the old > > p

Re: [PATCH 1/3] librust: Add libproc_macro and build system

On Wed, Sep 20, 2023 at 2:04 PM Arthur Cohen wrote: > > From: Pierre-Emmanuel Patry > > This patch series adds the build system changes to allow the Rust > frontend to develop and distribute its own libraries. The first library > we have been working on is the `proc_macro` library, comprised of a

Re: [PATCH 2/3] build: Add libgrust as compilation modules

On Wed, Sep 20, 2023 at 2:04 PM Arthur Cohen wrote: > > From: Pierre-Emmanuel Patry > > Define the libgrust directory as a host compilation module as well as > for targets. OK if you tested this doesn't break build when rust is enabled on trunk (and doesn't build libgrust if not). Richard. > C