Re: [PATCH] build: Check for cargo when building rust language

there is a way to cache and use those specific versions using cargo, that should be done but I suspect cargo does not work that way. Also any time someone says this is a temporary measure it is NOT and we should never treat it as such unless you already have a patch to remove it. Thanks, Andrew Pins

Re: [PATCH] build: Check for cargo when building rust language

On Mon, Apr 8, 2024 at 9:39 AM wrote: > > From: Pierre-Emmanuel Patry > > Hello, > > The rust frontend requires cargo to build some of it's components, > it's presence was not checked during configuration. WHY did this go in right before the release of GCC 14? I don't get why this is considered

[PATCH v2 1/4] rust: Use FLOAT_TYPE_P instead of manual checking

gcc/rust/ChangeLog: * rust-gcc.cc (is_floating_point): Use FLOAT_TYPE_P instead of manually checking the type. Signed-off-by: Andrew Pinski --- gcc/rust/rust-gcc.cc | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/gcc/rust/rust-gcc.cc b/gcc/rust

[PATCH v2 0/4] rust: Small cleanups of rust-gcc.cc

that help the readability. Andrew Pinski (4): rust: Use FLOAT_TYPE_P instead of manual checking rust: Use error_operand_p in rust-gcc.cc rust: use range for inside rust-gcc.cc [PR119341] rust: Add comment inside block [PR119342] gcc/rust/rust-gcc.cc

[PATCH v2 3/4] rust: use range for inside rust-gcc.cc [PR119341]

. (function_type_variadic): Likewise. (fill_in_fields): Likewise. (statement_list): Likewise. (block): Likewise. (block_add_statements): Likewise. (function_set_parameters): Likewise. (write_global_definitions): Likewise. Signed-off-by: Andrew Pinski

[PATCH v2 4/4] rust: Add comment inside block [PR119342]

-gcc.cc (block): Add comment on why chaining the variables of the scope toether. Signed-off-by: Andrew Pinski --- gcc/rust/rust-gcc.cc | 2 ++ 1 file changed, 2 insertions(+) diff --git a/gcc/rust/rust-gcc.cc b/gcc/rust/rust-gcc.cc index 1252798a87a..32d3aabbbe4 100644 --- a/gcc/rust/rust

[PATCH 2/4] rust: Use error_operand_p in rust-gcc.cc

. (write_global_definitions): Use error_operand_p. Tighten up the code around the loop. Signed-off-by: Andrew Pinski --- gcc/rust/rust-gcc.cc | 183 --- 1 file changed, 85 insertions(+), 98 deletions(-) diff --git a/gcc/rust/rust-gcc.cc b/gcc/rust/rust

[PATCH 3/4] rust: use range for inside rust-gcc.cc [PR119341]

. (function_type_variadic): Likewise. (fill_in_fields): Likewise. (statement_list): Likewise. (block): Likewise. (block_add_statements): Likewise. (function_set_parameters): Likewise. (write_global_definitions): Likewise. Signed-off-by: Andrew Pinski

[PATCH 1/4] rust: Use REAL_TYPE_P instead of manual checking

gcc/rust/ChangeLog: * rust-gcc.cc (is_floating_point): Use REAL_TYPE_P instead of manually checking the type. Signed-off-by: Andrew Pinski --- gcc/rust/rust-gcc.cc | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/gcc/rust/rust-gcc.cc b/gcc/rust/rust-g

[PATCH 4/4] rust: Add comment inside block [PR119342]

-gcc.cc (block): Add comment on why chaining the variables of the scope toether. Signed-off-by: Andrew Pinski --- gcc/rust/rust-gcc.cc | 2 ++ 1 file changed, 2 insertions(+) diff --git a/gcc/rust/rust-gcc.cc b/gcc/rust/rust-gcc.cc index 8a740f72513..53950a35fdc 100644 --- a/gcc/rust/rust

[PATCH v2 2/4] rust: Use error_operand_p in rust-gcc.cc

. (write_global_definitions): Use error_operand_p. Tighten up the code around the loop. Signed-off-by: Andrew Pinski --- gcc/rust/rust-gcc.cc | 189 --- 1 file changed, 88 insertions(+), 101 deletions(-) diff --git a/gcc/rust/rust-gcc.cc b/gcc/rust/rust

Re: [COMMITTED 09/42] gccrs: Add llvmInlineAsm node

On Mon, Apr 28, 2025 at 8:48 AM wrote: > > From: Pierre-Emmanuel Patry > > InlineAsm node does not support memory clobbers. A few review on this. I think this should just be called extended rather than referencing LLVM here. > > gcc/rust/ChangeLog: > > * ast/rust-ast-collector.cc (Token

Re: [PATCH][15.2] nr2.0: late: Correctly initialize funny_error member

On Tue, Apr 29, 2025 at 1:26 AM wrote: > > From: Arthur Cohen > > Hi everyone, > > We noticed inconsistent errors when running name-resolution 2.0 on > certain files, where an invalid error was triggered and the message was > from the `funny_ice` error finalizer function we had added as an easter

Re: [COMMITTED 09/42] gccrs: Add llvmInlineAsm node

On Mon, Apr 28, 2025 at 9:05 AM Andrew Pinski wrote: > > On Mon, Apr 28, 2025 at 8:48 AM wrote: > > > > From: Pierre-Emmanuel Patry > > > > InlineAsm node does not support memory clobbers. > > A few review on this. > I think this should just be called ext