Re: [PATCH] Pass pratt parsed token to expr parser functions to fix expr locus

2021-07-29 Thread Mark Wielaard
Hi Joel, On Thu, 2021-07-29 at 09:25 +0800, The Other via Gcc-rust wrote: > I think the core idea of this patch (fixing locations) is very > important and useful. > > But isn’t it overkill to pass the token in instead of just the > location? You can avoid a fairly expensive shared_ptr copy by doi

Re: [PATCH] Pass pratt parsed token to expr parser functions to fix expr locus

2021-07-29 Thread Thomas Schwinge
Hi! On 2021-07-29T12:55:38+0200, Mark Wielaard wrote: > On Thu, 2021-07-29 at 09:25 +0800, The Other via Gcc-rust wrote: >> I think the core idea of this patch (fixing locations) is very >> important and useful. Agreed. >> But isn’t it overkill to pass the token in instead of just the >> locati

Re: [PATCH] Pass pratt parsed token to expr parser functions to fix expr locus

2021-07-29 Thread Mark Wielaard
Hi, On Thu, Jul 29, 2021 at 05:18:50PM +0200, Thomas Schwinge wrote: > On 2021-07-29T12:55:38+0200, Mark Wielaard wrote: > > On Thu, 2021-07-29 at 09:25 +0800, The Other via Gcc-rust wrote: > >> But isn’t it overkill to pass the token in instead of just the > >> location? You can avoid a fairly e