Re: [PATCH] lex: accept zero codepoints in strings

2021-08-08 Thread Mark Wielaard
Hi Philip On Sun, Aug 08, 2021 at 01:36:21PM +0100, Philip Herron wrote: > This patch looks good to go but the clang-format check is failing: > https://github.com/Rust-GCC/gccrs/pull/615 > > The error seems to be that it moves the extra check onto a new line. > https://github.com/Rust-GCC/gccrs/p

Re: [PATCH] lex: accept zero codepoints in strings

2021-08-08 Thread Philip Herron
On 07/08/2021 16:45, Mark Wielaard wrote: > Zero characters (codepoints) are acceptable in strings. The current > Lexer::parse_string skipped such zero codepoints by accidents. The > zero codepoint was also used as error/skip indicator, but that is only > true if the third argument of utf8_escape_p