Re: [PATCH] Fix byte char and byte string lexing code

2021-09-23 Thread Arthur Cohen via Gcc-rust
> Something I was thinking about outside of the scope of that patch was about the utf8 how do they get represented? Is it some kind of wchar_t? Do you mean in C++ or in rustc? In rustc, they are represented as Unicode Scalar Values which are 4 bytes wide. >From the docs over here: [https://doc.ru

Re: [PATCH] Fix byte char and byte string lexing code

2021-09-23 Thread Philip Herron
Hi guys, Thanks, Thomas for raising the PR it is currently being merged. We will raise the next PR to get bootstrapable builds working which will be really nice there is a GitHub automation for that at the moment. Something I was thinking about outside of the scope of that patch was about the utf

Re: [PATCH] Fix byte char and byte string lexing code

2021-09-22 Thread Mark Wielaard
Hi Thomas, On Wed, Sep 22, 2021 at 11:48:56AM +0200, Thomas Schwinge wrote: > That's . > [...] > That's . Ah, sorry, I don't really track the github issues and had missed those. But good to see the analysis m

Re: [PATCH] Fix byte char and byte string lexing code

2021-09-22 Thread Thomas Schwinge
Hi Mark! On 2021-09-22T00:54:30+0200, Mark Wielaard wrote: > There were two warnings in lexer parse_byte_char and parse_byte_string > code for arches with signed chars: > > rust-lex.cc: In member function > ‘Rust::TokenPtr Rust::Lexer::parse_byte_char(Location)’: > rust-lex.cc:1564:2