Re: [COMMITTED 136/145] gccrs: Fix nightly rustc warnings

2025-04-04 Thread Thomas Schwinge
Hi Arthur! On 2025-03-22T15:48:18+0100, Arthur Cohen wrote: > Thanks for testing that commit. I think a partial revert is not > necessary, as I'm currently > working on our milestone to make all Rust code compile with a Rust > 1.49 toolchain. > > I think pushing a partial revert upstream would ju

Re: [COMMITTED 136/145] gccrs: Fix nightly rustc warnings

2025-03-22 Thread Thomas Schwinge
Hi! On 2025-03-17T16:33:34+0100, arthur.co...@embecosm.com wrote: > From: Kushal Pal > > libgrust/ChangeLog: > > * libformat_parser/Cargo.toml: > Used crate-type instead of depricated crate_type. > * libformat_parser/generic_format_parser/src/lib.rs: > Remove dead code. >

Re: [COMMITTED 136/145] gccrs: Fix nightly rustc warnings

2025-03-22 Thread Arthur Cohen
Hi Thomas! Thanks for testing that commit. I think a partial revert is not necessary, as I'm currently working on our milestone to make all Rust code compile with a Rust 1.49 toolchain. I think pushing a partial revert upstream would just create some confusion when the correct version of the code

[COMMITTED 136/145] gccrs: Fix nightly rustc warnings

2025-03-17 Thread arthur . cohen
From: Kushal Pal libgrust/ChangeLog: * libformat_parser/Cargo.toml: Used crate-type instead of depricated crate_type. * libformat_parser/generic_format_parser/src/lib.rs: Remove dead code. * libformat_parser/src/lib.rs: Likewise. Signed-off-by: Kushal Pal