Re: [PATCH] Pass pratt parsed token to expr parser functions to fix expr locus

2021-07-28 Thread The Other via Gcc-rust
I think the core idea of this patch (fixing locations) is very important and useful. But isn’t it overkill to pass the token in instead of just the location? You can avoid a fairly expensive shared_ptr copy by doing so. > On 29 Jul 2021, at 6:13 am, Mark Wielaard wrote: > > The pratt parser

Fwd: New contributor tasks

2021-07-17 Thread The Other via Gcc-rust
Sorry, pressed the wrong button. I meant to "reply all". -- Forwarded message - From: The Other Date: Sat, Jul 17, 2021 at 10:20 PM Subject: Re: New contributor tasks To: Philip Herron > The AST dump (--rust-dump-parse) was actually useful for checking the > comment doc strings