Re: [PING] [PATCH] rust: avoid clobbering LIBS

2024-09-04 Thread Richard Biener
On Tue, Sep 3, 2024 at 8:42 PM Marc wrote: > > Richard Biener writes: > > > On Wed, Aug 28, 2024 at 11:10 AM Marc wrote: > >> > >> Hello, > >> > >> Gentle reminder for this simple autoconf patch :) > > > > OK. > > > >

Re: [PING] [PATCH] rust: avoid clobbering LIBS

2024-08-28 Thread Richard Biener
On Wed, Aug 28, 2024 at 11:10 AM Marc wrote: > > Hello, > > Gentle reminder for this simple autoconf patch :) OK. Note that completely wiping LIBS might remove requirements detected earlier, like some systems require explicit -lc for example. I would instead not clear LIBS here and instead allo

Re: [PATCH] rust: Do not link with libdl and libpthread unconditionally

2024-05-31 Thread Richard Biener
On Fri, May 31, 2024 at 12:24 PM Arthur Cohen wrote: > > Hi Richard, > > On 4/30/24 09:55, Richard Biener wrote: > > On Fri, Apr 19, 2024 at 11:49 AM Arthur Cohen > > wrote: > >> > >> Hi everyone, > >> > >> This patch checks for the

Re: [PATCH] rust: Do not link with libdl and libpthread unconditionally

2024-04-30 Thread Richard Biener
On Fri, Apr 19, 2024 at 11:49 AM Arthur Cohen wrote: > > Hi everyone, > > This patch checks for the presence of dlopen and pthread_create in libc. If > that is not the > case, we check for the existence of -ldl and -lpthread, as these libraries > are required to > link the Rust runtime to our Ru

Re: [PATCH] build: Check for cargo when building rust language

2024-04-09 Thread Richard Biener
On Mon, Apr 8, 2024 at 6:39 PM wrote: > > From: Pierre-Emmanuel Patry > > Hello, > > The rust frontend requires cargo to build some of it's components, > it's presence was not checked during configuration. OK. Please work on documenting build requirements for rust in doc/install.texi, look for

Re: [PATCH 2/2] gccrs: fixup: Fix missing build dependency

2024-01-11 Thread Richard Biener
On Thu, 11 Jan 2024, Arthur Cohen wrote: > Hi Richard, > > On 1/11/24 15:23, Richard Biener wrote: > > On Thu, 11 Jan 2024, Arthur Cohen wrote: > > > >> From: Pierre-Emmanuel Patry > >> > >> Fix the missing dependency between the gcc and libgrust

Re: [PATCH 2/2] gccrs: fixup: Fix missing build dependency

2024-01-11 Thread Richard Biener
gcc: maybe-all-stageautoprofile-libgrust > +all-stageautofeedback-gcc: maybe-all-stageautofeedback-libgrust > all-gcc: maybe-all-gettext > all-stage1-gcc: maybe-all-stage1-gettext > all-stage2-gcc: maybe-all-stage2-gettext > -- Richard Biener SUSE Software Solutions Germany GmbH, Frankenstrasse 146, 90461 Nuernberg, Germany; GF: Ivo Totev, Andrew McDonald, Werner Knoblich; (HRB 36809, AG Nuernberg)

Re: [PATCH 2/3] build: Add libgrust as compilation modules

2023-09-26 Thread Richard Biener via Gcc-rust
On Wed, Sep 20, 2023 at 2:04 PM Arthur Cohen wrote: > > From: Pierre-Emmanuel Patry > > Define the libgrust directory as a host compilation module as well as > for targets. OK if you tested this doesn't break build when rust is enabled on trunk (and doesn't build libgrust if not). Richard. > C

Re: [PATCH 1/3] librust: Add libproc_macro and build system

2023-09-26 Thread Richard Biener via Gcc-rust
On Wed, Sep 20, 2023 at 2:04 PM Arthur Cohen wrote: > > From: Pierre-Emmanuel Patry > > This patch series adds the build system changes to allow the Rust > frontend to develop and distribute its own libraries. The first library > we have been working on is the `proc_macro` library, comprised of a

Re: [PATCHSET] Reintroduce targetrustm hooks

2023-09-14 Thread Richard Biener via Gcc-rust
On Wed, Sep 13, 2023 at 10:14 PM Iain Buclaw via Gcc-patches wrote: > > Excerpts from Arthur Cohen's message of September 7, 2023 3:41 pm: > > Alright, was not expecting to mess up this patchset so bad so here we go: > > > > This patchset reintroduces proper targetrustm hooks without the old > > p

Re: Rust front-end update 2023-04-05

2023-04-11 Thread Richard Biener via Gcc-rust
On Wed, Apr 5, 2023 at 4:06 PM wrote: > > Hi everyone, > > This patchset contains around 80 commits concerning the Rust frontend. > > We have been hard at work trying to get the Rust core library to > compile, and hope to push more commits in the coming days as we try > and upstream a more recent

Re: Rust: In 'type_for_mode' langhook also consider all 'int_n' modes/types (was: Modula-2 / Rust: Many targets failing)

2023-02-22 Thread Richard Biener via Gcc-rust
ug report, with preprocessed source (by using > -freport-bug). > Please include the complete backtrace with any bug report. > See <https://gcc.gnu.org/bugs/> for instructions. > make[1]: *** [s-selftest-rust] Error 1 > [...] > > OK to push the attached > &qu

Re: [PATCH] testsuite: Add support for Rust and Modula-2 effective target tests

2022-12-15 Thread Richard Biener via Gcc-rust
"*// D*" { set src ${basename}[pid].d } > "*// ObjC++*" { set src ${basename}[pid].mm } > "*/* ObjC*" { set src ${basename}[pid].m } > "*// Go*" { set src ${basename}[pid].go } > + "*// Rust*" { set src ${basename}[pid].rs

Re: Make '-frust-incomplete-and-experimental-compiler-do-not-use' a 'Common' option (was: Rust front-end patches v4)

2022-12-14 Thread Richard Biener via Gcc-rust
On Wed, Dec 14, 2022 at 11:58 PM Thomas Schwinge wrote: > > Hi! > > On 2022-12-13T14:40:36+0100, Arthur Cohen wrote: > > We've also added one more commit, which only affects files inside the > > Rust front-end folder. This commit adds an experimental flag, which > > blocks the compilation of Rust

Re: Rust front-end patches v4

2022-12-06 Thread Richard Biener via Gcc-rust
On Tue, Dec 6, 2022 at 11:11 AM wrote: > > This patchset contains the fixed version of our most recent patchset. We > have fixed most of the issues noted in the previous round of reviews, and are > keeping some for later as they would otherwise create too many conflicts with > our updated developm

Re: [PATCH Rust front-end v3 38/46] gccrs: Add HIR to GCC GENERIC lowering entry point

2022-11-29 Thread Richard Biener via Gcc-rust
On Tue, Nov 29, 2022 at 7:10 PM Arthur Cohen wrote: > > Hi Richard, > > (...) > > + > + unsigned HOST_WIDE_INT ltype_length > += wi::ext (wi::to_offset (TYPE_MAX_VALUE (ltype_domain)) > +- wi::to_offset (TYPE_MIN_VALUE (ltype_domain)) + 1, > >>> > >>> TYPE_

Re: [PATCH Rust front-end v3 38/46] gccrs: Add HIR to GCC GENERIC lowering entry point

2022-11-18 Thread Richard Biener via Gcc-rust
On Tue, Nov 15, 2022 at 2:46 PM Arthur Cohen wrote: > > > > On 11/9/22 14:53, Richard Biener wrote: > > On Wed, Oct 26, 2022 at 10:37 AM wrote: > >> > >> From: Philip Herron > >> > >> This patch contains the entry point and utilities used

Re: Rust frontend patches v3

2022-11-10 Thread Richard Biener via Gcc-rust
On Wed, Oct 26, 2022 at 10:16 AM wrote: > > This is the fixed version of our previous patch set for gccrs - We've adressed > the comments raised in our previous emails. > > This patch set does not contain any work that was not previously included, > such > as closure support, the constant evaluat

Re: [PATCH Rust front-end v3 38/46] gccrs: Add HIR to GCC GENERIC lowering entry point

2022-11-09 Thread Richard Biener via Gcc-rust
On Wed, Oct 26, 2022 at 10:37 AM wrote: > > From: Philip Herron > > This patch contains the entry point and utilities used for the lowering > of HIR nodes to `tree`s. It also contains a constant evaluator, ported > over from the C++ frontend. > > Co-authored-by: David Faust > Co-authored-by: Fai

Re: Rust frontend patches v3

2022-10-28 Thread Richard Biener via Gcc-rust
On Fri, Oct 28, 2022 at 1:45 PM Arthur Cohen wrote: > > Hi David, > > On 10/26/22 23:15, David Malcolm wrote: > > On Wed, 2022-10-26 at 10:17 +0200, arthur.co...@embecosm.com wrote: > >> This is the fixed version of our previous patch set for gccrs - We've > >> adressed > >> the comments raised in

Re: [PATCH Rust front-end v2 34/37] gccrs: add lang.opt

2022-09-14 Thread Richard Biener via Gcc-rust
On Wed, Sep 14, 2022 at 6:20 PM Thomas Schwinge wrote: > > Hi! > > On 2022-09-14T15:39:47+0200, Richard Biener via Gcc-patches > wrote: > > On Wed, Aug 24, 2022 at 2:13 PM wrote: > >> > >> From: Philip Herron > >> > >> We have some r

Re: [PATCH Rust front-end v2 07/37] gccrs: Add gcc-check-target check-rust

2022-09-14 Thread Richard Biener via Gcc-rust
On Wed, Aug 24, 2022 at 2:08 PM wrote: > > From: Philip Herron > > This allows us to invoke the rust testsuite. OK. > > ChangeLog: > * Makefile.def: Add autogen target > * Makefile.in: regenerate via autogen > --- > Makefile.def | 1 + > Makefile.in | 8 > 2 files cha

Re: [PATCH Rust front-end v2 33/37] gccrs: add lang-spec.h

2022-09-14 Thread Richard Biener via Gcc-rust
On Wed, Aug 24, 2022 at 2:20 PM wrote: > > From: Philip Herron > > This specifies the extensions of the Rust language. LGTM > --- > gcc/rust/lang-specs.h | 26 ++ > 1 file changed, 26 insertions(+) > create mode 100644 gcc/rust/lang-specs.h > > diff --git a/gcc/rust/la

Re: [PATCH Rust front-end v2 32/37] gccrs: Add config-lang.in

2022-09-14 Thread Richard Biener via Gcc-rust
On Wed, Aug 24, 2022 at 2:19 PM wrote: > > From: Philip Herron > > This was a copy paste from gccgo front-end, we do not use any of the > target_libs yet but we will need these when we support the libpanic crate. LGTM > --- > gcc/rust/config-lang.in | 34 ++ > 1

Re: [PATCH Rust front-end v2 34/37] gccrs: add lang.opt

2022-09-14 Thread Richard Biener via Gcc-rust
On Wed, Aug 24, 2022 at 2:13 PM wrote: > > From: Philip Herron > > We have some rust specific langugage options note -fwrapv is enabled by > default in the code. We are trying to respect options such as > -Wunused-result which we get by porting over c++ no-discard for rust's > must-use attribute,

Re: [PATCH Rust front-end v2 31/37] gccrs: Add GCC Rust front-end Make-lang.in

2022-09-14 Thread Richard Biener via Gcc-rust
On Wed, Aug 24, 2022 at 2:22 PM wrote: > > From: Philip Herron > > This is the Makefile for our front-end. > --- > gcc/rust/Make-lang.in | 400 ++ > 1 file changed, 400 insertions(+) > create mode 100644 gcc/rust/Make-lang.in > > diff --git a/gcc/rust/Mak

Re: [PATCH Rust front-end v2 09/37] gccrs: Add Lexer for Rust front-end

2022-09-14 Thread Richard Biener via Gcc-rust
On Wed, Aug 24, 2022 at 2:04 PM wrote: > > From: The Other > > The lexer is refered to as a ManagedTokenSource within the parser, this > lexer does not currently support unicode but serves as a starting point > to do so. > > Co-authored-by: Philip Herron > Co-authored-by: Arthur Cohen > Co-auth

Re: Rust front-end

2022-07-11 Thread Richard Biener via Gcc-rust
tches? Yes, that's the prefered way. Having an integration branch ready for people to play with is also useful - if you are ready you might want to push something like that to the gcc.gnu.org repository under the devel/ namespace. Thanks, Richard. > Again thanks to everyone for helpi

Re: Rust front-end

2022-06-28 Thread Richard Biener via Gcc-rust
On Mon, Jun 27, 2022 at 4:52 PM Philip Herron wrote: > > Hi everyone, > > Since November 2020, I've worked full-time on the Rust front-end for > GCC, thanks to Open Source Security, Inc and Embecosm. As a result, I > am writing to this mailing list to seek feedback from the collective > experience